Update sub_show_status() reference with status values#429
Conversation
📝 WalkthroughWalkthroughDocumentation for Changes
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Up to standards ✅🟢 Issues
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docs/spock_functions/functions/spock_sub_show_status.md`:
- Around line 57-58: The parameter description for subscription_name in the
spock_sub_show_status documentation is indented with four spaces and is being
rendered as a code block; update the
docs/spock_functions/functions/spock_sub_show_status.md entry for
subscription_name (the parameter in the spock_sub_show_status function) by
removing the leading four-space indentation and making it plain prose (or
convert it to a proper definition-list style), so the sentence "Optional. The
name of a specific Spock subscription. If NULL (the default), the function
returns status for all subscriptions." renders as normal text instead of a code
block.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 347587e4-765b-4ed4-a2f3-09000fcafb15
📒 Files selected for processing (1)
docs/spock_functions/functions/spock_sub_show_status.md
|
Looks like there are merge conflicts. |
…tting fixes Add a STATUS VALUES table documenting all five possible subscription states (replicating, initializing, disabled, down, unknown) derived from the C source. Fix heading markup, wrap synopsis in a fenced SQL code block, and add introductory sentences before examples. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
0150ae7 to
0b05113
Compare
There was a problem hiding this comment.
🧹 Nitpick comments (1)
docs/spock_functions/functions/spock_sub_show_status.md (1)
17-23: Optional wording polish for the Returns bullets.Lines 17-23 repeatedly start with “the”; consider parallel concise labels (or a small column table) to make scanning easier.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/spock_functions/functions/spock_sub_show_status.md` around lines 17 - 23, Replace the repeated "the" phrasing in the Returns bullets of docs/spock_functions/functions/spock_sub_show_status.md with concise, parallel labels (e.g., "Subscription name", "Replication status", "Provider node", "Connection string", "Logical replication slot", "Replication sets", "Forwarded origins") or convert the list into a compact two-column table with label and short description so the items scan easily while preserving the same information; update the Returns section for clarity under the spock_sub_show_status documentation.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@docs/spock_functions/functions/spock_sub_show_status.md`:
- Around line 17-23: Replace the repeated "the" phrasing in the Returns bullets
of docs/spock_functions/functions/spock_sub_show_status.md with concise,
parallel labels (e.g., "Subscription name", "Replication status", "Provider
node", "Connection string", "Logical replication slot", "Replication sets",
"Forwarded origins") or convert the list into a compact two-column table with
label and short description so the items scan easily while preserving the same
information; update the Returns section for clarity under the
spock_sub_show_status documentation.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 60d28f5c-1678-4d54-ba57-aa7311d8cda1
📒 Files selected for processing (1)
docs/spock_functions/functions/spock_sub_show_status.md
This resolves spoc-361
Add a STATUS VALUES table documenting all five possible subscription states (replicating, initializing, disabled, down, unknown) derived from the C source. Fix heading markup, wrap synopsis in a fenced SQL code block, and add introductory sentences before examples.