Skip to content

Conversation

cvvergara
Copy link
Member

@cvvergara cvvergara commented Jul 7, 2025

Changes proposed in this pull request:

Adds SV to the CI, and the build

@pgRouting/admins

Summary by CodeRabbit

  • New Features

    • Added comprehensive Swedish translations for all major workshop documentation, including basic, advanced, appendix, examples, general introduction, interactions, UN SDG chapters, and index.
    • Swedish is now available as a supported language in the documentation and language selection options.
  • Chores

    • Updated workflow and build configuration to support Swedish translations and adjusted documentation versioning.
    • Removed the development tag from the workshop version string.

cvvergara and others added 8 commits July 3, 2025 07:34
Co-authored-by: Celia Virginia Vergara Castillo <vicky@erosion.dev>
Co-authored-by: Weblate <noreply@weblate.org>
Currently translated at 100.0% (38 of 38 strings)

Translated using Weblate (Swedish)

Currently translated at 100.0% (52 of 52 strings)

Translated using Weblate (Swedish)

Currently translated at 100.0% (57 of 57 strings)

Translated using Weblate (Swedish)

Currently translated at 100.0% (149 of 149 strings)

Translated using Weblate (Swedish)

Currently translated at 100.0% (15 of 15 strings)

Translated using Weblate (Swedish)

Currently translated at 100.0% (41 of 41 strings)

Translated using Weblate (Swedish)

Currently translated at 100.0% (146 of 146 strings)

Translated using Weblate (Swedish)

Currently translated at 100.0% (158 of 158 strings)

Translated using Weblate (Swedish)

Currently translated at 100.0% (137 of 137 strings)

Translated using Weblate (Swedish)

Currently translated at 100.0% (18 of 18 strings)

Translated using Weblate (Swedish)

Currently translated at 100.0% (40 of 40 strings)

Translated using Weblate (Swedish)

Currently translated at 100.0% (71 of 71 strings)

Translated using Weblate (Swedish)

Currently translated at 100.0% (52 of 52 strings)

Translated using Weblate (Swedish)

Currently translated at 100.0% (86 of 86 strings)

Translated using Weblate (Swedish)

Currently translated at 100.0% (86 of 86 strings)

Translated using Weblate (Swedish)

Currently translated at 100.0% (55 of 55 strings)

Translated using Weblate (Swedish)

Currently translated at 100.0% (11 of 11 strings)

Translated using Weblate (Swedish)

Currently translated at 63.6% (7 of 11 strings)

Translated using Weblate (Swedish)

Currently translated at 100.0% (7 of 7 strings)

Translated using Weblate (Swedish)

Currently translated at 100.0% (104 of 104 strings)

Translated using Weblate (Swedish)

Currently translated at 100.0% (4 of 4 strings)

Translated using Weblate (Swedish)

Currently translated at 100.0% (55 of 55 strings)

Translated using Weblate (Swedish)

Currently translated at 100.0% (5 of 5 strings)

Translated using Weblate (Swedish)

Currently translated at 3.4% (3 of 86 strings)

Translated using Weblate (Swedish)

Currently translated at 0.9% (1 of 104 strings)

Translated using Weblate (Swedish)

Currently translated at 2.6% (1 of 38 strings)

Translated using Weblate (Swedish)

Currently translated at 1.9% (1 of 52 strings)

Translated using Weblate (Swedish)

Currently translated at 1.7% (1 of 57 strings)

Translated using Weblate (Swedish)

Currently translated at 0.6% (1 of 149 strings)

Translated using Weblate (Swedish)

Currently translated at 0.6% (1 of 146 strings)

Translated using Weblate (Swedish)

Currently translated at 0.7% (1 of 137 strings)

Translated using Weblate (Swedish)

Currently translated at 2.5% (1 of 40 strings)

Translated using Weblate (Swedish)

Currently translated at 1.4% (1 of 71 strings)

Translated using Weblate (Swedish)

Currently translated at 1.8% (1 of 55 strings)

Translated using Weblate (Swedish)

Currently translated at 1.1% (1 of 86 strings)

Translated using Weblate (Swedish)

Currently translated at 100.0% (40 of 40 strings)

Translated using Weblate (Swedish)

Currently translated at 1.1% (1 of 86 strings)

Translated using Weblate (Swedish)

Currently translated at 100.0% (35 of 35 strings)

Added translation using Weblate (Swedish)

Added translation using Weblate (Swedish)

Added translation using Weblate (Swedish)

Added translation using Weblate (Swedish)

Added translation using Weblate (Swedish)

Added translation using Weblate (Swedish)

Added translation using Weblate (Swedish)

Added translation using Weblate (Swedish)

Added translation using Weblate (Swedish)

Added translation using Weblate (Swedish)

Added translation using Weblate (Swedish)

Added translation using Weblate (Swedish)

Added translation using Weblate (Swedish)

Added translation using Weblate (Swedish)

Added translation using Weblate (Swedish)

Added translation using Weblate (Swedish)

Added translation using Weblate (Swedish)

Added translation using Weblate (Swedish)

Added translation using Weblate (Swedish)

Added translation using Weblate (Swedish)

Added translation using Weblate (Swedish)

Added translation using Weblate (Swedish)

Added translation using Weblate (Swedish)

Translated using Weblate (Swedish)

Currently translated at 100.0% (55 of 55 strings)

Co-authored-by: Daniel Nylander <daniel@danielnylander.se>
Translate-URL: https://weblate.osgeo.org/projects/pgrouting-workshop/advanced-chapter-12/sv/
Translate-URL: https://weblate.osgeo.org/projects/pgrouting-workshop/appendix-appendix-2/sv/
Translate-URL: https://weblate.osgeo.org/projects/pgrouting-workshop/appendix-appendix-3/sv/
Translate-URL: https://weblate.osgeo.org/projects/pgrouting-workshop/appendix-appendix-4/sv/
Translate-URL: https://weblate.osgeo.org/projects/pgrouting-workshop/basic-data/sv/
Translate-URL: https://weblate.osgeo.org/projects/pgrouting-workshop/basic-graph_views/sv/
Translate-URL: https://weblate.osgeo.org/projects/pgrouting-workshop/basic-pedestrian/sv/
Translate-URL: https://weblate.osgeo.org/projects/pgrouting-workshop/basic-plpgsql_function/sv/
Translate-URL: https://weblate.osgeo.org/projects/pgrouting-workshop/basic-sql_function/sv/
Translate-URL: https://weblate.osgeo.org/projects/pgrouting-workshop/basic-vehicle/sv/
Translate-URL: https://weblate.osgeo.org/projects/pgrouting-workshop/examples-boost_dijkstra/sv/
Translate-URL: https://weblate.osgeo.org/projects/pgrouting-workshop/examples-hanoslav/sv/
Translate-URL: https://weblate.osgeo.org/projects/pgrouting-workshop/examples-wiki_example/sv/
Translate-URL: https://weblate.osgeo.org/projects/pgrouting-workshop/general-intro-introduction/sv/
Translate-URL: https://weblate.osgeo.org/projects/pgrouting-workshop/general-intro-osgeolive/sv/
Translate-URL: https://weblate.osgeo.org/projects/pgrouting-workshop/general-intro-overview/sv/
Translate-URL: https://weblate.osgeo.org/projects/pgrouting-workshop/interactions-chapter-10/sv/
Translate-URL: https://weblate.osgeo.org/projects/pgrouting-workshop/interactions-chapter-11/sv/
Translate-URL: https://weblate.osgeo.org/projects/pgrouting-workshop/interactions-chapter-9/sv/
Translate-URL: https://weblate.osgeo.org/projects/pgrouting-workshop/un_sdg-data/sv/
Translate-URL: https://weblate.osgeo.org/projects/pgrouting-workshop/un_sdg-introduction/sv/
Translate-URL: https://weblate.osgeo.org/projects/pgrouting-workshop/un_sdg-sdg11-cities/sv/
Translate-URL: https://weblate.osgeo.org/projects/pgrouting-workshop/un_sdg-sdg3-health/sv/
Translate-URL: https://weblate.osgeo.org/projects/pgrouting-workshop/un_sdg-sdg7-energy/sv/
Translation: pgRouting workshop/advanced-chapter-12
Translation: pgRouting workshop/appendix-appendix-2
Translation: pgRouting workshop/appendix-appendix-3
Translation: pgRouting workshop/appendix-appendix-4
Translation: pgRouting workshop/basic-data
Translation: pgRouting workshop/basic-graph_views
Translation: pgRouting workshop/basic-pedestrian
Translation: pgRouting workshop/basic-plpgsql_function
Translation: pgRouting workshop/basic-sql_function
Translation: pgRouting workshop/basic-vehicle
Translation: pgRouting workshop/examples-boost_dijkstra
Translation: pgRouting workshop/examples-hanoslav
Translation: pgRouting workshop/examples-wiki_example
Translation: pgRouting workshop/general-intro-introduction
Translation: pgRouting workshop/general-intro-osgeolive
Translation: pgRouting workshop/general-intro-overview
Translation: pgRouting workshop/interactions-chapter-10
Translation: pgRouting workshop/interactions-chapter-11
Translation: pgRouting workshop/interactions-chapter-9
Translation: pgRouting workshop/un_sdg-data
Translation: pgRouting workshop/un_sdg-introduction
Translation: pgRouting workshop/un_sdg-sdg11-cities
Translation: pgRouting workshop/un_sdg-sdg3-health
Translation: pgRouting workshop/un_sdg-sdg7-energy
Copy link

coderabbitai bot commented Jul 7, 2025

Walkthrough

This update introduces Swedish localization for the entire Workshop FOSS4G Belém 3.0 documentation, adding numerous .po translation files across all chapters and appendices. It also updates CMake and GitHub Actions workflows to support Swedish, modifies the version suffix, and adjusts documentation deployment logic for the main branch.

Changes

File(s) Change Summary
.github/workflows/ubuntu.yml, .github/workflows/website.yml Updated CMake configuration to enable Swedish (-DSV=ON), and changed documentation deployment folder for main.
CMakeLists.txt Removed "-dev" version suffix; added Swedish ("sv") to supported documentation languages and language map.
locale/sv/LC_MESSAGES/... (multiple files for advanced, appendix, basic, examples, etc.) Added comprehensive Swedish translation files for all workshop chapters, appendices, examples, and introductions.
locale/sv/LC_MESSAGES/index.po Added Swedish translation template for documentation index (currently untranslated entries).

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant GitHub Actions
    participant CMake
    participant Docs Generator

    User->>GitHub Actions: Push or PR triggers workflow
    GitHub Actions->>CMake: Run with -DES=ON -DSV=ON
    CMake->>Docs Generator: Generate docs in English, Spanish, Japanese, Swedish
    Docs Generator->>GitHub Actions: Output built documentation
    GitHub Actions->>GitHub Pages: Deploy docs (main branch → "3.0" folder)
Loading

Suggested labels

administrative

Suggested reviewers

  • robe2

Poem

A rabbit hops with Swedish cheer,
New languages for all to hear!
Docs now sing in Svenska too,
With workflows fresh and version new.
From graphs to roads, from health to tree,
This workshop speaks in harmony!
🐇🌍✨


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@cvvergara cvvergara added this to the FOSS4G 2024 milestone Jul 7, 2025
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 10

🔭 Outside diff range comments (1)
.github/workflows/ubuntu.yml (1)

54-57: .pgpass needs 0600 permissions to be honoured by psql

psql ignores a .pgpass file that is world-readable. Add a chmod 600 .pgpass right after the echo commands to avoid authentication surprises in CI.

   echo :5432:*:runner:runner >> .pgpass
+  chmod 600 .pgpass
   sudo -u postgres psql -c 'CREATE ROLE "user" SUPERUSER CREATEDB CREATEROLE INHERIT LOGIN PASSWORD $$user$$;' -d setup
   echo :5432:*:user:user >> .pgpass
+  chmod 600 .pgpass
♻️ Duplicate comments (1)
locale/sv/LC_MESSAGES/examples/hanoslav.po (1)

56-58: Same typo carried over

The English source has tranlasted SQL commands. Correct upstream .rst and regenerate POT/PO files to avoid inconsistent keys.

🧹 Nitpick comments (19)
.github/workflows/website.yml (1)

95-99: Hard-coded release folder may break future patch releases

FOLDER_NAME="3.0" ties the main-branch deployment to one minor version. When 3.1 or 3.0.1 ships, docs will overwrite the wrong location or require another code change.

Consider deriving the folder name from PGR_WORKSHOP_VERSION_MAJOR + PGR_WORKSHOP_VERSION_MINOR (exported by CMake or echoed via cmake -LA).

CMakeLists.txt (1)

289-290: Language map entry added – minor nitpick on alphabetical order

For readability keep INSERT_INTO_MAP entries alphabetically sorted; inserting sv after pt would preserve order.

 INSERT_INTO_MAP("pt" "Portugus")
+INSERT_INTO_MAP("sv" "Svenska")
 INSERT_INTO_MAP("ru" "Русский")
-INSERT_INTO_MAP("sv" "Svenska")
locale/sv/LC_MESSAGES/examples/wiki_example.po (2)

1-5: Replace placeholder header metadata before merge

# SOME DESCRIPTIVE TITLE. and # FIRST AUTHOR <EMAIL@ADDRESS>, YEAR. are still template placeholders. Leaving them unchanged clutters translation statistics and may confuse downstream tooling that relies on header metadata.

No functional impact, but worth cleaning up while the file is still fresh.


27-32: Minor wording – “Dijkstra-problem” reads smoother without “enkla”

pgRouting kan lösa enkla Dijkstra-problem … is perfectly understandable, but Swedish style guides normally avoid the adjective “enkla” in technical descriptions unless it adds value. Consider the leaner:

-"pgRouting kan lösa enkla Dijkstra-problem, såsom exemplet på Wikipedia …
+"pgRouting kan lösa Dijkstra-problem, såsom exemplet på Wikipedia …

Purely stylistic – ignore if you prefer the current phrasing.

locale/sv/LC_MESSAGES/general-intro/introduction.po (1)

134-138: Typo in original reflected in translation — “Lead engenieer”

The source string contains “Lead engenieer”. You kept the misspelling (“ingenjör” is correct in Swedish).
While translators normally do not fix source errors, Sphinx will render your Swedish text. Consider:

- Ledande ingenjör för ParkUpFront
+ Ledande ingenjör för ParkUpFront

(i.e. just correct “ingenjör”).

locale/sv/LC_MESSAGES/interactions/chapter-9.po (1)

69-72: Replicated typos from source – opportunity to clean up

The English string has several misspellings (posgGIS, enabeled, potsgreSQL).
Your Swedish translation currently keeps “posgGIS-aktiverad postgreSQL”. Consider correcting to:

-Anslut till en posgGIS-aktiverad postgreSQL-databas […]
+Anslut till en PostGIS-aktiverad PostgreSQL-databas […]

Improves readability without altering meaning.

locale/sv/LC_MESSAGES/basic/data.po (1)

108-113: Minor spelling – “form” → “från”

Alternativ 2) Ladda ner data form OSGeoLive website… från …:

-msgstr "Alternativ 2) Ladda ner data form OSGeoLives webbplats"
+msgstr "Alternativ 2) Ladda ner data från OSGeoLives webbplats"
locale/sv/LC_MESSAGES/general-intro/osgeolive.po (1)

85-88: Consistent product naming – use “VirtualBox” everywhere

The Swedish string renders “Virtual box” (two-word, lowercase) while the upstream product name is “VirtualBox”. Please update to avoid branding/potential glossary mismatches across the docs.

-Installera Virtual box med hjälp av:
+Installera VirtualBox med hjälp av:
locale/sv/LC_MESSAGES/interactions/chapter-10.po (1)

118-120: Minor wording – “Skicka” already implies a button; drop the quotes

Line reads:
Tryck sedan på knappen "Skicka".

Quotes are unnecessary and break the style used elsewhere.

-Tryck sedan på knappen "Skicka".
+Tryck sedan på knappen Skicka.
locale/sv/LC_MESSAGES/interactions/chapter-11.po (1)

103-107: Phrase is awkward Swedish

Linje för linje har vi det: is clunky; prefer concise “Rad för rad:”

-Linje för linje har vi det:
+Rad för rad:
locale/sv/LC_MESSAGES/appendix/appendix-3.po (1)

42-50: Nit: consider using proper ReST link markup for osm2po

For consistency with the surrounding text, wrap the URL with back-tick
syntax:

- "(https://osm2po.de)"
+ "(`osm2po <https://osm2po.de>`__)"
locale/sv/LC_MESSAGES/basic/plpgsql_function.po (1)

318-322: Tiny typo – “disconected” → “disconnected”

Although only in a comment line, fixing keeps the translation polished.

- "Det är upp till läsaren att ta bort borttagna komponenter på vyerna."
+ "Det är upp till läsaren att ta bort bortkopplade komponenter i vyerna."
locale/sv/LC_MESSAGES/general-intro/overview.po (1)

26-33: Grammar/clarity

A double “programvaror … programvarorna” makes the sentence hard to
follow. Consider tightening:

- "I denna workshop används flera programvaror med fri och öppen källkod för geospatiala verktyg. De flesta av de fria och öppna källkodsprogramvarorna för geospatiala verktyg som är relaterade till andra programvaruprojekt med öppen källkod."
+ "I denna workshop används flera geospatiala verktyg med fri och öppen källkod. De flesta av dem är dessutom kopplade till andra öppna källkodsprojekt."
locale/sv/LC_MESSAGES/un_sdg/sdg7-energy.po (2)

1-5: Replace template header placeholders

Please swap the boiler-plate header lines
# SOME DESCRIPTIVE TITLE. and # FIRST AUTHOR <EMAIL@ADDRESS>, YEAR.
for meaningful values (or remove them). They leak into the compiled catalog
headers and look unpolished in downstream tooling.


118-126: Typos inherited from the source – fix while translating

seach path (msgid) is clearly a typo for “search path”.
The Swedish msgstr currently reads “Ange sökväg för sökning” which keeps the
error and becomes confusing. Consider

-msgstr "Övning 1: Ange sökväg för sökning"
+msgstr "Övning 1: Ange sökvägen (search path)"

to both correct the English slip and improve clarity for readers.

locale/sv/LC_MESSAGES/basic/pedestrian.po (1)

1-5: Clean up placeholder header comments

Same remark as in other .po files: provide an actual title or drop the
# SOME DESCRIPTIVE TITLE. / # FIRST AUTHOR … lines.

locale/sv/LC_MESSAGES/basic/vehicle.po (1)

1-5: Header still contains template stubs

Please replace or delete the placeholder header comments to keep the catalog
metadata tidy.

locale/sv/LC_MESSAGES/basic/sql_function.po (1)

1-5: Remove boiler-plate header lines

The template markers at the top of the file should be replaced with real
information or removed before merge.

locale/sv/LC_MESSAGES/un_sdg/sdg11-cities.po (1)

1-5: Template placeholders left in header

Please clean up # SOME DESCRIPTIVE TITLE. and
# FIRST AUTHOR <EMAIL@ADDRESS>, YEAR. so they don’t propagate to the final
.mo file.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2b2c8f4 and b8875e0.

📒 Files selected for processing (28)
  • .github/workflows/ubuntu.yml (1 hunks)
  • .github/workflows/website.yml (2 hunks)
  • CMakeLists.txt (3 hunks)
  • locale/sv/LC_MESSAGES/advanced/chapter-12.po (1 hunks)
  • locale/sv/LC_MESSAGES/appendix/appendix-2.po (1 hunks)
  • locale/sv/LC_MESSAGES/appendix/appendix-3.po (1 hunks)
  • locale/sv/LC_MESSAGES/appendix/appendix-4.po (1 hunks)
  • locale/sv/LC_MESSAGES/basic/data.po (1 hunks)
  • locale/sv/LC_MESSAGES/basic/graph_views.po (1 hunks)
  • locale/sv/LC_MESSAGES/basic/pedestrian.po (1 hunks)
  • locale/sv/LC_MESSAGES/basic/plpgsql_function.po (1 hunks)
  • locale/sv/LC_MESSAGES/basic/sql_function.po (1 hunks)
  • locale/sv/LC_MESSAGES/basic/vehicle.po (1 hunks)
  • locale/sv/LC_MESSAGES/examples/boost_dijkstra.po (1 hunks)
  • locale/sv/LC_MESSAGES/examples/hanoslav.po (1 hunks)
  • locale/sv/LC_MESSAGES/examples/wiki_example.po (1 hunks)
  • locale/sv/LC_MESSAGES/general-intro/introduction.po (1 hunks)
  • locale/sv/LC_MESSAGES/general-intro/osgeolive.po (1 hunks)
  • locale/sv/LC_MESSAGES/general-intro/overview.po (1 hunks)
  • locale/sv/LC_MESSAGES/index.po (1 hunks)
  • locale/sv/LC_MESSAGES/interactions/chapter-10.po (1 hunks)
  • locale/sv/LC_MESSAGES/interactions/chapter-11.po (1 hunks)
  • locale/sv/LC_MESSAGES/interactions/chapter-9.po (1 hunks)
  • locale/sv/LC_MESSAGES/un_sdg/data.po (1 hunks)
  • locale/sv/LC_MESSAGES/un_sdg/introduction.po (1 hunks)
  • locale/sv/LC_MESSAGES/un_sdg/sdg11-cities.po (1 hunks)
  • locale/sv/LC_MESSAGES/un_sdg/sdg3-health.po (1 hunks)
  • locale/sv/LC_MESSAGES/un_sdg/sdg7-energy.po (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Build
🔇 Additional comments (10)
.github/workflows/ubuntu.yml (1)

62-62: Swedish flag correctly added – no further action needed

-DSV=ON is consistent with the new SV CMake option introduced in CMakeLists.txt, so the workflow will now build Swedish docs as intended.

.github/workflows/website.yml (1)

75-75: Swedish build flag looks good

cmake -DES=ON -DSV=ON .. mirrors the Ubuntu workflow and matches the CMake options.

CMakeLists.txt (2)

29-30: Removing -dev suffix clarifies release artifacts

Dropping the -dev tag (PGR_WORKSHOP_VERSION_DEV now empty) is fine; downstream scripts already rely on the numeric ${PGR_WORKSHOP_RELEASE} so no breakage expected.


224-225: Swedish added to supported languages – remember to enable docs on CI

The language is correctly appended to PGR_WORKSHOP_SUPPORTED_LANGUAGES. CI workflows already pass -DSV=ON, so the pipeline is consistent.

locale/sv/LC_MESSAGES/examples/boost_dijkstra.po (2)

37-40: Source string typo leaks into translations

tranlasted SQL commands in the msgid is misspelled. Fix the English .rst, then re-extract POTs; translators will automatically inherit the corrected string.


22-25: Translation looks accurate

The Swedish title matches the canonical pgRouting terminology.

locale/sv/LC_MESSAGES/examples/hanoslav.po (1)

22-29: Consistent, clear Swedish translation

No issues spotted; terminology aligns with the Boost example.

locale/sv/LC_MESSAGES/index.po (1)

2-14: Headers still contain placeholders & translations are all empty

The header blocks (FULL NAME, EMAIL@ADDRESS, etc.) are placeholders.
More importantly, every msgstr is empty – Swedish readers will see the English fallback for the top-level index.

If this file is intentionally left untranslated for now, mark each entry #, fuzzy so tooling reports the todo. Otherwise, translate before enabling -DSV=ON in CI to avoid an incomplete landing page.

locale/sv/LC_MESSAGES/appendix/appendix-4.po (1)

22-47: Looks good – translations & inline code are preserved

All placeholders, links and back-quoted literals are kept intact. No issues spotted.

locale/sv/LC_MESSAGES/un_sdg/sdg3-health.po (1)

224-231: Preserve literal geometry type – “LINESTRING”, not “LINGSTING”.

The source string contains a typo, but tutorials later rely on the exact word LINESTRING. Keep it unchanged in Swedish to avoid confusion.

- "innehåller byggnader av typen ``LINGSTING``."
+ "innehåller byggnader av typen ``LINESTRING``."

Comment on lines +163 to +165
#: ../../build/docs/interactions/chapter-9.rst:108
msgid ":menuselection:`Style --> Color`"
msgstr ":menyval:`Stil --> Färg`"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Role name accidentally changed – Sphinx will fail

msgstr replaces the reST role :menuselection: with :menyval::

-msgstr ":menyval:`Stil --> Färg`"
+msgstr ":menuselection:`Stil --> Färg`"

menyval is not a registered role; Sphinx will emit a warning/error and render the literal text instead of nice UI highlighting.

🤖 Prompt for AI Agents
In locale/sv/LC_MESSAGES/interactions/chapter-9.po around lines 163 to 165, the
msgstr incorrectly changes the reST role from :menuselection: to :menyval:,
which is not a valid Sphinx role. To fix this, revert the role in msgstr back to
:menuselection: so it matches the original msgid and ensures proper Sphinx
rendering without warnings or errors.

Comment on lines +179 to +183
#: ../../build/docs/interactions/chapter-9.rst:123
msgid "Choose a formmated layer and :menuselection:`Right click --> Styles --> Copy Styles`"
msgstr ""
"Välj ett förminskat lager och :menyval:`Högerklicka --> Stilar --> Kopiera "
"stilar`"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Same issue – keep :menuselection: and fix Swedish wording

-":menyval:`Högerklicka --> Stilar --> Kopiera stilar`"
+":menuselection:`Högerklicka --> Stilar --> Kopiera stilar`"

While here, “förminskat lager” should be “formaterat lager”.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
#: ../../build/docs/interactions/chapter-9.rst:123
msgid "Choose a formmated layer and :menuselection:`Right click --> Styles --> Copy Styles`"
msgstr ""
"Välj ett förminskat lager och :menyval:`Högerklicka --> Stilar --> Kopiera "
"stilar`"
#: ../../build/docs/interactions/chapter-9.rst:123
msgid "Choose a formmated layer and :menuselection:`Right click --> Styles --> Copy Styles`"
msgstr ""
"Välj ett förminskat lager och :menuselection:`Högerklicka --> Stilar --> Kopiera "
"stilar`"
🤖 Prompt for AI Agents
In locale/sv/LC_MESSAGES/interactions/chapter-9.po around lines 179 to 183, the
msgid uses :menuselection: but the Swedish translation uses :menyval: which is
inconsistent. Also, the Swedish phrase "förminskat lager" is incorrect and
should be "formaterat lager". Update the Swedish msgstr to use :menuselection:
and correct the wording to "formaterat lager" to match the original meaning.

Comment on lines +85 to +89
msgid "To avoid permission denied errors for local users you can set connection method to ``trust`` in ``/etc/postgresql/<version>/main/pg_hba.conf`` and restart PostgreSQL server with ``sudo service postgresql restart``."
msgstr ""
"För att undvika fel med nekad behörighet för lokala användare kan du ställa "
"in anslutningsmetod till ``trust`` i ``/etc/postgresql/<version>/main/pg_hba."
"conf`` och starta om PostgreSQL-servern med ```sudo service postgresql "
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Extra back-tick breaks reStructuredText build

The command snippet gained three back-ticks at the front ( ```sudo …) instead of the required two.
This will render incorrectly and may fail rst2html/Sphinx.

-... och starta om PostgreSQL-servern med ```sudo service postgresql restart``.
+... och starta om PostgreSQL-servern med ``sudo service postgresql restart``.
🤖 Prompt for AI Agents
In locale/sv/LC_MESSAGES/appendix/appendix-2.po around lines 85 to 89, the
translated msgstr has three back-ticks before the command "sudo service
postgresql restart" instead of two, which breaks the reStructuredText
formatting. Fix this by changing the triple back-ticks to double back-ticks so
the command is properly enclosed and renders correctly in rst2html/Sphinx.

Comment on lines +369 to +373
msgid "More on Sustainable Development Goals can be found at this `link <https://sdgs.un.org/goals>`__."
msgstr ""
"Mer om målen för hållbar utveckling finns på denna länk <https://sdgs.un.org/"
"goals>`__."

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Missing leading back-tick in inline link markup – will break the RST build

msgid uses the ReST pattern `link <url>\__. msgstr` lost the opening back-tick, so Sphinx will treat “länk” as plain
text and raise a syntax error during the Swedish build.

- "Mer om målen för hållbar utveckling finns på denna länk <https://sdgs.un.org/goals>`__."
+ "Mer om målen för hållbar utveckling finns på denna `länk <https://sdgs.un.org/goals>`__."

Committable suggestion skipped: line range outside the PR's diff.

🤖 Prompt for AI Agents
In locale/sv/LC_MESSAGES/un_sdg/introduction.po around lines 369 to 373, the
translated string msgstr is missing the leading back-tick before "länk" in the
inline link markup, which breaks the ReST syntax. Add the opening back-tick
before "länk" so the link markup matches the msgid pattern `link <url>`__,
ensuring the Sphinx build does not fail.

Comment on lines +67 to +71
msgid "If you don't have pgRouting installed. You can find the installation procedure at this `link <https://docs.pgrouting.org/latest/en/pgRouting-installation.html>`__"
msgstr ""
"Om du inte har pgRouting installerat. Du kan hitta installationsproceduren "
"på den här länken <https://docs.pgrouting.org/latest/en/pgRouting-"
"installation.html>`__"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Same markup regression here

The back-tick before “länken” is again missing, leading to broken
documentation.

- "på den här länken <https://docs.pgrouting.org/latest/en/pgRouting-installation.html>`__"
+ "på den här `länken <https://docs.pgrouting.org/latest/en/pgRouting-installation.html>`__"

Committable suggestion skipped: line range outside the PR's diff.

🤖 Prompt for AI Agents
In locale/sv/LC_MESSAGES/un_sdg/data.po around lines 67 to 71, the translation
string is missing the opening back-tick before “länken,” causing broken markup.
Add the missing back-tick before “länken” in the msgstr to correctly match the
original msgid formatting and fix the documentation rendering.

Comment on lines +50 to +53
msgstr ""
"Du kan ange när grafen ska betraktas som \"riktad\" <https://en.wikipedia."
"org/wiki/Directed_graph>`__ eller \"oriktad\"."

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Broken reST link markup – will fail the docs build

The msgstr keeps a stray back-tick after the URL:

Du kan ange när grafen ska betraktas som "riktad" <https://en.wikipedia.org/wiki/Directed_graph>`__ ...

Sphinx treats that as a syntax error. Mirror the original
link syntax instead:

-"Du kan ange när grafen ska betraktas som \"riktad\" <https://en.wikipedia.org/wiki/Directed_graph>`__ eller \"oriktad\"."
+"Du kan ange när grafen ska betraktas som `riktad <https://en.wikipedia.org/wiki/Directed_graph>`__ eller oriktad."

Test make html locally – the build should pass again.

🤖 Prompt for AI Agents
In locale/sv/LC_MESSAGES/basic/pedestrian.po around lines 50 to 53, the reST
link markup in the msgstr contains a stray back-tick after the URL, causing the
docs build to fail. Remove the back-tick after the URL and ensure the link
syntax matches the original working format without extra characters. After
fixing, run `make html` locally to verify the build passes.

Comment on lines +151 to +153
msgid "Assigns a ``source`` and a ``target`` identifiers to each road link"
msgstr "Tilldelar en ``käll`` och en ``mål`` identifiering till varje väglänk"

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Spelling error in translated identifier – should be “källa”, not “käll”.

- "Tilldelar en ``käll`` och en ``mål`` identifiering …"
+ "Tilldelar en ``källa`` och en ``mål``-identifiering …"
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
msgid "Assigns a ``source`` and a ``target`` identifiers to each road link"
msgstr "Tilldelar en ``käll`` och en ``mål`` identifiering till varje väglänk"
msgid "Assigns a ``source`` and a ``target`` identifiers to each road link"
-msgstr "Tilldelar en ``käll`` och en ``mål`` identifiering till varje väglänk"
+msgstr "Tilldelar en ``källa`` och en ``mål``-identifiering till varje väglänk"
🤖 Prompt for AI Agents
In locale/sv/LC_MESSAGES/advanced/chapter-12.po around lines 151 to 153, correct
the spelling of the Swedish word "käll" to "källa" in the msgstr translation to
fix the spelling error in the identifier translation.

Comment on lines +42 to +46
msgid "In this chapter you will learn how to create a basic `Routing Network Topology` from a network data that does not have a routing Topology create the minimum attributes needed the `Routing Network Topology`."
msgstr ""
"I det här kapitlet lär du dig att skapa en grundläggande `Routing Network "
"Topology` från nätverksdata som inte har någon routing Topology skapa de "
"minimiattribut som behövs för `Routing Network Topology`."
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Do not translate code identifiers (source_osm / target_osm).

source_osm and target_osm are column names that must stay exactly as-is. Translating them will break copy-paste SQL snippets and confuse users.

- "… baserade på ``källans_osm`` och ``målets_osm``."
+ "… baserade på ``source_osm`` och ``target_osm``."

Committable suggestion skipped: line range outside the PR's diff.

🤖 Prompt for AI Agents
In locale/sv/LC_MESSAGES/advanced/chapter-12.po around lines 42 to 46, the
translation incorrectly modifies code identifiers. Ensure that the column names
`source_osm` and `target_osm` remain exactly as-is in the translation without
any changes, as translating them will break SQL snippets and confuse users.
Update the msgstr to keep these identifiers unchanged.

Comment on lines +196 to +201
#: ../../build/docs/basic/graph_views.rst:145
msgid "Update the ``geom`` columns based on the ``source_osm`` column from ``ways`` table."
msgstr ""
"Uppdatera kolumnerna ``geom`` baserat på kolumnen ``ource_osm`` från "
"tabellen ``ways``."

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Accidental typo in column name (ource_osm).

- "baserat på kolumnen ``ource_osm`` …"
+ "baserat på kolumnen ``source_osm`` …"
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
#: ../../build/docs/basic/graph_views.rst:145
msgid "Update the ``geom`` columns based on the ``source_osm`` column from ``ways`` table."
msgstr ""
"Uppdatera kolumnerna ``geom`` baserat på kolumnen ``ource_osm`` från "
"tabellen ``ways``."
#: ../../build/docs/basic/graph_views.rst:145
msgid "Update the ``geom`` columns based on the ``source_osm`` column from ``ways`` table."
msgstr ""
"Uppdatera kolumnerna ``geom`` baserat på kolumnen ``source_osm`` från "
"tabellen ``ways``."
🤖 Prompt for AI Agents
In locale/sv/LC_MESSAGES/basic/graph_views.po around lines 196 to 201, there is
a typo in the translation string where "ource_osm" should be corrected to
"source_osm". Fix the typo by updating the translation to use the correct column
name "source_osm".

Comment on lines +40 to +46
#: ../../build/docs/basic/graph_views.rst:26
msgid "In this chapter there are three graph requirements. It consists on three graphs based on a **fully connected** graph derived from ``ways``: two for different types of vehicles and one for pedestrian, the source and the target in all of them are based on the ``source_osm`` and ``target_osm``."
msgstr ""
"I det här kapitlet finns det tre grafkrav. Det består av tre grafer baserade "
"på en **fullständigt sammanhängande** graf som härrör från ``vägar``: två "
"för olika typer av fordon och en för fotgängare, källan och målet i dem alla "
"är baserade på ``källans_osm`` och ``målets_osm``."
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Keep literal column names unchanged.

source_osm / target_osm were translated, breaking later references.

- "… baserade på ``källans_osm`` och ``målets_osm``."
+ "… baserade på ``source_osm`` och ``target_osm``."
🤖 Prompt for AI Agents
In locale/sv/LC_MESSAGES/basic/graph_views.po around lines 40 to 46, the literal
column names `source_osm` and `target_osm` were translated, which breaks
references in the code. To fix this, revert these two terms back to their
original untranslated forms `source_osm` and `target_osm` in the Swedish
translation string while keeping the rest of the translation intact.

@cvvergara cvvergara merged commit 1a7e1d6 into pgRouting:develop Jul 7, 2025
2 checks passed
@cvvergara cvvergara deleted the adding-sv-to-the-build branch July 7, 2025 18:02
This was referenced Sep 24, 2025
This was referenced Oct 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants