Samair#2
Merged
pgaref merged 4 commits intopgaref:masterfrom Jul 13, 2016
Merged
Conversation
Owner
|
Thanks for the PR! I like the css parsing step but there seem to be two different styles currently in the proxy page - the first one is causing parser failure:
PS: Some proper exception handling could help in such cases. As a step further you could also take a look at issue #4 if you are interested. Cheers, |
Contributor
Author
|
I've improved the extraction of the css link so, if order or page is changed, it'll still work:
|
Owner
|
Looks good, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added samari.ru to be parsed