Fix formatting of bindgenned files by piping through prettyplease.#2020
Closed
thomcc wants to merge 1 commit intopgcentralfoundation:developfrom
Closed
Fix formatting of bindgenned files by piping through prettyplease.#2020thomcc wants to merge 1 commit intopgcentralfoundation:developfrom
prettyplease.#2020thomcc wants to merge 1 commit intopgcentralfoundation:developfrom
Conversation
Contributor
Contributor
Author
|
Ah, alright. I'll assume it does. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, some bindgenned files (the pg17.rs in my work codebase) end up too big for rustfmt to handle, so it just gives up and spits out the input directly. The tool designed for this purpose is the
prettypleasecrate, which produces semi-formatted output (not identical to rustfmt), that rustfmt can take as input.