Make the pgversion optional when set in features. #402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ana Hobden <operator@hoverbear.org>
Signed-off-by: Ana Hobden <operator@hoverbear.org>
Contributor
Author
|
I need to update the docs! |
Hoverbear
commented
Jan 25, 2022
Signed-off-by: Ana Hobden <operator@hoverbear.org>
Signed-off-by: Ana Hobden <operator@hoverbear.org>
Signed-off-by: Ana Hobden <operator@hoverbear.org>
Signed-off-by: Ana Hobden <operator@hoverbear.org>
Signed-off-by: Ana Hobden <operator@hoverbear.org>
Signed-off-by: Ana Hobden <operator@hoverbear.org>
Contributor
Author
|
Okay I think this is finally ready. Sheesh. Now to do docs. |
Signed-off-by: Ana Hobden <operator@hoverbear.org>
Signed-off-by: Ana Hobden <operator@hoverbear.org>
Signed-off-by: Ana Hobden <operator@hoverbear.org>
Merged
usamoi
pushed a commit
to tensorchord/pgrx
that referenced
this pull request
Mar 6, 2025
…n#402) * Remove requirement for pgversion Signed-off-by: Ana Hobden <operator@hoverbear.org> * Refactor a bit Signed-off-by: Ana Hobden <operator@hoverbear.org> * fmt Signed-off-by: Ana Hobden <operator@hoverbear.org> * Improve feature flag handling Signed-off-by: Ana Hobden <operator@hoverbear.org> * Refine test feature handling Signed-off-by: Ana Hobden <operator@hoverbear.org> * Refine flag usage in test Signed-off-by: Ana Hobden <operator@hoverbear.org> * Let invalid pgversion be testname Signed-off-by: Ana Hobden <operator@hoverbear.org> * Ensure pg_test is on tests Signed-off-by: Ana Hobden <operator@hoverbear.org> * Remove leftover debug panic Signed-off-by: Ana Hobden <operator@hoverbear.org> * Tidy docs and consistency in commands Signed-off-by: Ana Hobden <operator@hoverbear.org> * Add remaining readme bits Signed-off-by: Ana Hobden <operator@hoverbear.org> * fix pgx connect requiring manifest Signed-off-by: Ana Hobden <operator@hoverbear.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #388 .