It's not necessary for pgx to add a CONTEXT message to the ereport #875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… pgx doesn't (currently) have any more context than funcname/file:line:col info, which we already store in the LOCATION slot. If in the future pgx learns how to build a backtrace (and it might be interesting for it to do that for level >=ERROR messages), the context slot is where that information should go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pgx doesn't (currently) have any more context than
funcname/file:line:col info, which we already store in the LOCATION slot. If in the future pgx learns how to build a backtrace (and it might be interesting for it to do that for level >=ERROR messages), the context slot is where that information should go.@yrashk brought this up on Discord.