Conversation
Contributor
Hoverbear
commented
Jul 4, 2022
Hoverbear
commented
Merged
eeeebbbbrrrr
reviewed
Jul 5, 2022
| Some(String::from_utf8(output.stdout.clone()).expect("`cargo`'s stdout was not UTF-8")), | ||
| Some(String::from_utf8(output.stderr.clone()).expect("`cargo`'s stderr was not UTF-8")), | ||
| Some( | ||
| String::from_utf8(output.stdout.clone()).expect("`cargo`'s stdout was not UTF-8"), |
Contributor
There was a problem hiding this comment.
nit: extra space before UTF-8
| String::from_utf8(output.stdout.clone()).expect("`cargo`'s stdout was not UTF-8"), | ||
| ), | ||
| Some( | ||
| String::from_utf8(output.stderr.clone()).expect("`cargo`'s stderr was not UTF-8"), |
Contributor
|
Should probably look into the CI failures, eh? |
Merged
Signed-off-by: Ana Hobden <operator@hoverbear.org>
Comment on lines
+67
to
+72
| let composite_type_oid: u32 = unsafe { | ||
| let mut typoid = 0; | ||
| let mut typmod = 0; | ||
| pg_sys::parseTypeString("Dog".as_pg_cstr(), &mut typoid, &mut typmod, false); | ||
| typoid | ||
| }; |
Member
There was a problem hiding this comment.
Need to find a way to wrap this outside this function before this is acceptable.
eeeebbbbrrrr
added a commit
that referenced
this pull request
May 24, 2023
eeeebbbbrrrr
added a commit
that referenced
this pull request
May 31, 2023
Merged
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.