add pg 18 support and set it as default #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastianwebber
force-pushed
the
seba/pg18
branch
2 times, most recently
from
6e5bccf to
976fae6
Compare
This PR introduces full support for PostgreSQL 18, including new AIO-related parameters (io_workers, io_method, etc.) and profiles. It also significantly improves the CI/CD pipeline reliability: - Integration Tests: Added comprehensive container-based tests for PostgreSQL versions 9.5 through 18. - Robustness: Implemented strict failure detection for container crashes and timeouts. - Verification: Added script validation to ensure generated configs are accepted by the actual database engine. - Coverage: Fixed Coveralls reporting by using proper token authentication and package-wide coverage collection. - Documentation: Updated AGENTS.md with strict commit conventions and agent rules. Signed-off-by: Sebastian Webber <sebastian@swebber.me>
sebastianwebber
force-pushed
the
seba/pg18
branch
from
f69b5e2 to
0141295
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several significant improvements to the project, focusing on expanding PostgreSQL 18 support, enhancing CI/CD workflows, updating dependencies, and improving documentation for both users and contributors. The most notable changes are grouped below.
PostgreSQL 18 Support and Rules Engine Enhancements
pkg/defaults/pg.go. [1] [2]io_method,io_workers,io_max_combine_limit,io_max_concurrency,file_copy_method, etc.) inpkg/category/storage.goand ensured they are included in the generated documentation and configuration defaults. [1] [2] [3]README.mdto clarify how configuration is adjusted based on environment and version, including new rules for PostgreSQL 18+ features.CI/CD and Testing Improvements
.github/workflows/integration.yml) that builds the CLI, generates configs, spins up PostgreSQL containers for versions 9.5–18, and verifies parameter application.go.mod, removed unnecessary matrix strategies, and improved reliability. [1] [2] [3]Makefile.Dependency and Go Version Updates
go.mod, ensuring compatibility and improved security.Documentation and Contributor Guidance
AGENTS.mdguide for AI agents and contributors, outlining essential commands, project structure, code patterns, commit conventions, and common pitfalls.Other Notable Improvements
generators/pg-docs/main.go) and cleaned up code. [1] [2]These changes collectively modernize the project, improve reliability across PostgreSQL versions, and make it easier for new contributors and automation agents to understand and work with the codebase.