Remove unused QueryWithoutComment#1023
Merged
Merged
Conversation
We reimplemented our own Cow for this, which isn't necessarily unreasonable but wasn't needed here for a few reasons. The first is that we don't actually have an Owned case. The code appears to be written assuming that you can't take a subslice of a string with the same lifetime as the original, which isn't true. The only other reason we'd keep this is if we cared whether a query had a comment or not at some future point, but no code ever checks for this. We can reasonably determine this by checking if role and shard are both Some.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We reimplemented our own Cow for this, which isn't necessarily unreasonable but wasn't needed here for a few reasons. The first is that we don't actually have an Owned case. The code appears to be written assuming that you can't take a subslice of a string with the same lifetime as the original, which isn't true.
The only other reason we'd keep this is if we cared whether a query had a comment or not at some future point, but no code ever checks for this. We can reasonably determine this by checking if role and shard are both Some.