fix: role detection; feat: set inside transactions#647
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This comment has been minimized.
This comment has been minimized.
Contributor
|
Found 1 test failure on Blacksmith runners: Failure
|
dev-lew
pushed a commit
to dev-lew/pgdog
that referenced
this pull request
Feb 18, 2026
The role detection was pretty bad, it was causing an infinite loop on role change and DoSing itself. Now, we're using atomics on load balancer targets, so we don't need to reload the config when role changes. For `SET`, we now handle it inside transactions and run it on the client's behalf. This makes it work when `cross_shard_disabled = true`. Additionally, all `SET` commands executed inside a transaction are rewritten to use `SET LOCAL` instead to avoid leaking client state between servers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The role detection was pretty bad, it was causing an infinite loop on role change and DoSing itself. Now, we're using atomics on load balancer targets, so we don't need to reload the config when role changes.
For
SET, we now handle it inside transactions and run it on the client's behalf. This makes it work whencross_shard_disabled = true. Additionally, allSETcommands executed inside a transaction are rewritten to useSET LOCALinstead to avoid leaking client state between servers.