Skip to content

fix: handle transaction state correctly with advisory locks#801

Merged
levkk merged 2 commits intomainfrom
levkk-advisory-lock-transaction-mode
Mar 3, 2026
Merged

fix: handle transaction state correctly with advisory locks#801
levkk merged 2 commits intomainfrom
levkk-advisory-lock-transaction-mode

Conversation

@levkk
Copy link
Collaborator

@levkk levkk commented Mar 2, 2026

fix #798

We were buffering BEGIN in session mode, which was then not sent to the server, when combined with advisory lock checking.

@levkk levkk force-pushed the levkk-advisory-lock-transaction-mode branch from fa6fb9e to 873d3e9 Compare March 2, 2026 23:41
@levkk levkk merged commit 588329d into main Mar 3, 2026
7 checks passed
@levkk levkk deleted the levkk-advisory-lock-transaction-mode branch March 3, 2026 00:05
@codecov
Copy link

codecov bot commented Mar 3, 2026

Codecov Report

❌ Patch coverage is 92.30769% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pgdog/src/frontend/router/parser/route.rs 60.00% 4 Missing ⚠️
.../frontend/client/query_engine/start_transaction.rs 93.33% 1 Missing ⚠️
pgdog/src/frontend/router/parser/function.rs 80.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

transaction commit failed: pq: unexpected transaction status idle with golang-migrate in transaction mode

1 participant