Fix exclude primary with no replicas

[mijoharas]

As above, fixes #804

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

[mijoharas]

oh, one other thing that's tangentially related. I keep getting bindings changes, I've been ignoring and not committing them, but just wanted to check that's what we should be doing?

[levkk]

oh, one other thing that's tangentially related. I keep getting bindings changes, I've been ignoring and not committing them, but just wanted to check that's what we should be doing?

Ah yeah, we should of gitignored that one. I tried to make git ignore all future changes to that file, with no success. You can commit those or not - they are regenerated at build time anyway.

[mijoharas]

Oh... it's already in .gitignore... I thought that worked? Hmmm... there are some hacks here:
https://stackoverflow.com/questions/3319479/can-i-git-commit-a-file-and-ignore-its-content-changes
but it says they're recommended against.

Should we just git rm it and commit (I can raise a PR for that if you want)? gitignore should then keep it ignored after that I think.

[mijoharas]

oh... no the build fails if that's removed... because we have pub mod bindings in lib.rs 🤔 . So the build.rs generates the file, but we need that to happen before it tries to load lib, which it does as part of the build...

Bit of a catch-22 here.

[mijoharas]

ok, I've got something here: #809