Skip to content

fix: table LSN not preserved during copy -> replication handover#874

Merged
levkk merged 2 commits intomainfrom
levkk-fix-off-by-one
Apr 7, 2026
Merged

fix: table LSN not preserved during copy -> replication handover#874
levkk merged 2 commits intomainfrom
levkk-fix-off-by-one

Conversation

@levkk
Copy link
Copy Markdown
Collaborator

@levkk levkk commented Apr 7, 2026

  • fix: regression introduced in fix: omnisharded resharding copy and replication #869 erasing table LSNs during copy to replication handover, causing rows written between slot creation and copy start replayed on the destination
  • fix: off-by-one in replication to copy LSN check
  • fix: advancing LSN prior to transaction commit, potentially skipping rows in the same transaction

@levkk levkk changed the title fix: table lsns not preserved during copy -> replication handover fix: table LSN not preserved during copy -> replication handover Apr 7, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 7, 2026

Codecov Report

❌ Patch coverage is 91.01124% with 16 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...nd/replication/logical/publisher/publisher_impl.rs 82.08% 12 Missing ⚠️
...c/backend/replication/logical/subscriber/stream.rs 93.75% 3 Missing ⚠️
...rc/backend/replication/logical/subscriber/tests.rs 98.41% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@levkk levkk merged commit 004f03b into main Apr 7, 2026
9 of 10 checks passed
@levkk levkk deleted the levkk-fix-off-by-one branch April 7, 2026 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant