Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
frodsan
reviewed
Apr 10, 2026
| conn = connect 'pgdog', 'pgdog' | ||
| conn.exec_params 'SELECT $1', [1] | ||
| conn.exec "SELECT 1" | ||
| conn.exec "SET lock_timeout TO sdfs" |
There was a problem hiding this comment.
Any ideas why the error is raised later and not here? 🤔
Collaborator
Author
There was a problem hiding this comment.
We intercept SET statements and execute them only when a real query is sent.
This was referenced Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was caused by the following conditions:
query_parser = "on", soSETstatements are interceptedruby-pgdriver initialized withapplication_name: ''so it wouldn't runSET application_name TO xSET, e.g.SET lock_timeout to sdfThis was caused by us not resetting extended protocol state in our protocol state machine and allowing invalid
SETstatements to be executed in a batch.