feat: demo add synth events #332
Conversation
|
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx affected -t lint typecheck test --parallel -... |
❌ Failed | 15s | View ↗ |
☁️ Nx Cloud last updated this comment at 2025-11-11 14:45:40 UTC
🔍 Preview Deployment: Website✅ Deployment successful! 🔗 Preview URL: https://pr-332.pgflow.pages.dev 📝 Details:
_Last updated: _ |
🔍 Preview Deployment: Demo✅ Deployment successful! 🔗 Preview URL: https://pr-332-pgflow-demo.jumski.workers.dev 📝 Details:
_Last updated: _ |
jumski
force-pushed
the
feat-demo-synth-events
branch
from
dd7cb02 to
63d7289
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| stateVersion; | ||
| return run?.step(stepSlug).status || 'created'; | ||
| }, |
There was a problem hiding this comment.
Critical bug: Optional chaining is incomplete. When run is null, run?.step(stepSlug) returns undefined, then accessing .status on undefined will throw a TypeError.
// Current (broken):
return run?.step(stepSlug).status || 'created';
// Fixed:
return run?.step(stepSlug)?.status || 'created';This affects all property getters in the step() function (status, output, error, started_at, completed_at, failed_at) and will crash whenever these properties are accessed before a run is started or after it's cleared.
| stateVersion; | |
| return run?.step(stepSlug).status || 'created'; | |
| }, | |
| stateVersion; | |
| return run?.step(stepSlug)?.status || 'created'; | |
| }, |
Spotted by Graphite Agent
Is this helpful? React 👍 or 👎 to let us know.
| // Ensure reactivity to step status changes by accessing flowState.run | ||
| void flowState.run; |
There was a problem hiding this comment.
Replace 'void flowState.run' with a proper
Spotted by Graphite Agent (based on CI logs)
Is this helpful? React 👍 or 👎 to let us know.
| let lastEventCount = $state(0); | ||
| $effect(() => { | ||
| const currentEventCount = flowState.events.length; | ||
| const currentEventCount = flowState.timeline.length; |
There was a problem hiding this comment.
Ensure the timeline implementation uses SvelteDate instead of the built-in Date class for reactivity. If the timeline is created in pgflow-state.svelte, make sure all Date instances are replaced with SvelteDate there.
Spotted by Graphite Agent (based on CI logs)
Is this helpful? React 👍 or 👎 to let us know.
jumski
force-pushed
the
feat-demo-synth-events
branch
from
63d7289 to
7d9e3a0
Compare
jumski
force-pushed
the
feat-demo-final-deploy-fixes
branch
from
4069c1b to
00a42ab
Compare
| // Use reactive step() method from runState | ||
| return flowState.step(stepSlug).status === 'started'; |
There was a problem hiding this comment.
The comment here is redundant since the code already clearly shows we're using the step() method. Consider removing the comment to make the code cleaner.
Spotted by Graphite Agent (based on CI logs)
Is this helpful? React 👍 or 👎 to let us know.
jumski
force-pushed
the
feat-demo-synth-events
branch
from
7d9e3a0 to
84196b4
Compare
jumski
force-pushed
the
feat-demo-final-deploy-fixes
branch
from
00a42ab to
5e1c8fa
Compare
jumski
force-pushed
the
feat-demo-synth-events
branch
from
84196b4 to
7d29fe5
Compare
jumski
force-pushed
the
feat-demo-final-deploy-fixes
branch
from
5e1c8fa to
259e682
Compare
jumski
force-pushed
the
feat-demo-synth-events
branch
from
7d29fe5 to
96d0289
Compare
No description provided.