Skip to content

introduce prepush git hook #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

introduce prepush git hook #408

wants to merge 1 commit into from

Conversation

@jumski
Copy link
Contributor

@jumski jumski commented Nov 21, 2025

  • Adds a 'prepush' target to multiple projects that includes fast-running checks
  • Enables caching selectively in multiple prepush dependencies
  • Adds a pre-push git hook to lefthook.yml that invokes prepush with nx affected

@jumski jumski mentioned this pull request Nov 21, 2025
Closed
@changeset-bot
Copy link

changeset-bot bot commented Nov 21, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 9815af4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jumski Graphite App
Copy link
Contributor Author

jumski commented Nov 21, 2025 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge:queue - adds this PR to the back of the merge queue
  • hotfix:queue - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jumski jumski mentioned this pull request Nov 21, 2025
Open
@nx-cloud
Copy link

nx-cloud bot commented Nov 21, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 9815af4

Command Status Duration Result
nx affected -t test:e2e --parallel --base=origi... ✅ Succeeded 6m 29s View ↗
nx affected -t verify-exports --base=origin/mai... ✅ Succeeded 3s View ↗
nx affected -t build --configuration=production... ✅ Succeeded 25s View ↗
nx affected -t lint typecheck test --parallel -... ✅ Succeeded 4m 9s View ↗

☁️ Nx Cloud last updated this comment at 2025-11-21 12:07:08 UTC

@graphite-app graphite-app bot changed the base branch from 11-20-docs_setup_context7.json_fix_missing_deno_version_updates to graphite-base/408 November 21, 2025 11:57
@graphite-app graphite-app bot force-pushed the 11-21-introduce_prepush_git_hook branch from 25ae7f4 to 7f2a5be Compare November 21, 2025 11:58
@chatgpt-codex-connector
Copy link

chatgpt-codex-connector bot commented Nov 21, 2025

💡 Codex Review

pgflow/lefthook.yml

Lines 57 to 60 in 25ae7f4

pre-push:
commands:
'nx-affected-checks':
run: pnpm nx affected --target=prepush --base=origin/main --head=HEAD --output-style=static

P1 Badge Pre-push hook skips checks for projects without prepush

The new pre-push hook runs pnpm nx affected --target=prepush, but only the handful of projects that now declare a prepush target will be executed. Projects like apps/demo, pkgs/example-flows, and pkgs/website still have no prepush target, so changes to them will now run zero lint/build verification before push, whereas the previous hook still executed their existing targets. This regression means pushes touching those projects can bypass all validation.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@graphite-app graphite-app bot changed the base branch from graphite-base/408 to main November 21, 2025 11:58
@graphite-app graphite-app bot force-pushed the 11-21-introduce_prepush_git_hook branch from 7f2a5be to 9815af4 Compare November 21, 2025 11:58
@github-actions
Copy link
Contributor

github-actions bot commented Nov 21, 2025

🔍 Preview Deployment: Website

✅ Deployment successful!

🔗 Preview URL: https://pr-408.pgflow.pages.dev

📝 Details:

  • Branch: 11-21-introduce_prepush_git_hook
  • Commit: 99b352254407771a7dc47328eae45a6f11edb129
  • View Logs

_Last updated: _

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 21, 2025 •
edited
Loading

Merge activity

  • Nov 21, 12:28 PM UTC: jumski added this pull request to the Graphite merge queue.
  • Nov 21, 12:28 PM UTC: CI is running for this pull request on a draft pull request (#411) due to your merge queue CI optimization settings.
  • Nov 21, 12:29 PM UTC: Merged by the Graphite merge queue via draft PR: #411.

graphite-app bot pushed a commit that referenced this pull request Nov 21, 2025
@jumski
introduce prepush git hook (#408)
a0cb075 
- Adds a 'prepush' target to multiple projects that includes fast-running checks
- Enables caching selectively in multiple prepush dependencies
- Adds a pre-push git hook to lefthook.yml that invokes prepush with nx affected
@graphite-app graphite-app bot closed this Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jumski