Skip to content

Conversation

@jumski
Copy link
Contributor

@jumski jumski commented Dec 1, 2025

Remove Flow Compilation Verification Endpoint

This PR removes the /flows/:slug/ensure-compiled endpoint and its associated functionality from the Edge Worker control plane. The endpoint was designed to verify flow compilation against database records, but is no longer needed in the current architecture.

Changes include:

  • Removed the /flows/:slug/ensure-compiled endpoint handler
  • Removed related interfaces: EnsureCompiledResponse, EnsureCompiledRequest, ControlPlaneOptions, and SqlFunction
  • Simplified the createControlPlaneHandler function by removing the optional configuration parameter
  • Removed authentication verification logic that was only used by this endpoint
  • Removed all tests related to the endpoint and its functionality

This change streamlines the control plane API to focus on its core functionality of serving compiled flows.

@changeset-bot
Copy link

changeset-bot bot commented Dec 1, 2025

⚠️ No Changeset found

Latest commit: 8875a41

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor Author

jumski commented Dec 1, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge:queue - adds this PR to the back of the merge queue
  • hotfix:queue - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@nx-cloud
Copy link

nx-cloud bot commented Dec 1, 2025

View your CI Pipeline Execution ↗ for commit 8875a41

Command Status Duration Result
nx affected -t verify-exports --base=origin/mai... ✅ Succeeded 3s View ↗
nx affected -t build --configuration=production... ✅ Succeeded 25s View ↗
nx affected -t lint typecheck test --parallel -... ✅ Succeeded 3m 51s View ↗
nx run edge-worker:e2e ✅ Succeeded 2m 51s View ↗
nx run cli:e2e ✅ Succeeded 3s View ↗

☁️ Nx Cloud last updated this comment at 2025-12-01 09:48:53 UTC

@jumski jumski changed the base branch from 12-01-move_local_environment_detection_from_flowworkerlifecycle_to_platformadapter to graphite-base/476 December 1, 2025 09:39
@jumski jumski force-pushed the 12-01-remove_unused_ensure-compiled_http_endpoint_from_controlplane branch from 481f162 to 8875a41 Compare December 1, 2025 09:40
@jumski jumski force-pushed the graphite-base/476 branch from 88f515d to 7440546 Compare December 1, 2025 09:40
@jumski jumski changed the base branch from graphite-base/476 to 12-01-move_local_environment_detection_from_flowworkerlifecycle_to_platformadapter December 1, 2025 09:40
@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2025

🔍 Preview Deployment: Website

Deployment successful!

🔗 Preview URL: https://pr-476.pgflow.pages.dev

📝 Details:

  • Branch: 12-01-remove_unused_ensure-compiled_http_endpoint_from_controlplane
  • Commit: 9720a239bb5077da8e48ab55d67af6e4cd0d00ae
  • View Logs

_Last updated: _

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants