Skip to content

Conversation

@62mkv
Copy link

@62mkv 62mkv commented Apr 5, 2020

This change adds an alias currentSchema for schema configuration parameter; and uses this value as a value for "search_path" connection option (instead of executing SET SCHEMA TO command upon connection)

[resolves #271 ]

Make sure that:

  • You have read the contribution guidelines.
  • You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
  • You use the code formatters provided here and have them applied to your changes. Don't submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.

Issue description

Closes #271

New Public APIs

Additional context

…nection options (instead of `SET SCHEMA TO` command execution upon connection)
@62mkv
Copy link
Author

62mkv commented Apr 7, 2020

hi @mp911de is to too bad for review? just to clarify: I've left one action (about formatters) unchecked, because when I applied (or thought to have applied) the recommended style and ran the Code Reformat action in IntelliJ, the code was re-formatted heavily so I had to manually adjust it.

It still feels that making something like (in PostgresqlConnectionFactoryProvider.java)

Map<String, String> options;
if (connectionFactoryOptions.getValue(OPTIONS)) instanceof String) {
   options = tryParseOptions(connectionFactoryOptions.getValue(OPTIONS));
} else {
   options = connectionFactoryOptions.getValue(OPTIONS);
}

might be a more generic way to address this (and similar) issues. What do you think ?

@mp911de
Copy link
Collaborator

mp911de commented Apr 7, 2020

No worries. We weren't able yet to review this PR as we're busy with other projects.

@mp911de mp911de closed this in f314e47 Apr 24, 2020
mp911de added a commit that referenced this pull request Apr 24, 2020
Decouple options map creation. Return unmodifiable options map to prevent unwanted modifications. Add since tag.

[#271][resolves #272]
@mp911de
Copy link
Collaborator

mp911de commented Apr 24, 2020

Thank you for your contribution. That's merged, polished, and backported now.

@mp911de mp911de added this to the 0.8.3.RELEASE milestone Apr 24, 2020
@mp911de mp911de added the type: enhancement A general enhancement label Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: enhancement A general enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add support for providing "search_path" connection option

2 participants