Skip to content

Housekeeping: typing literals, fix tests#65

Merged
FeodorFitsner merged 7 commits intopglet:mainfrom
mikaelho:mikaelho-literals-and-tests
Feb 13, 2022
Merged

Housekeeping: typing literals, fix tests#65
FeodorFitsner merged 7 commits intopglet:mainfrom
mikaelho:mikaelho-literals-and-tests

Conversation

@mikaelho
Copy link
Copy Markdown
Contributor

This PR:

  1. Brings Literal support in Python 3.7 with typing_extensions
  2. Fixes tests so that they all run
    • Converting string-based tests as-is to Command-based asserts (and removing indent parameter if there)
    • Fixing some obsolete arguments in tests
    • Moving the page fixture to the standard conftest.py for reusability.

Recommend review by commit, as some of them only contain boilerplate changes.

@FeodorFitsner FeodorFitsner merged commit 39aa105 into pglet:main Feb 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants