Add Smart Identifier Quoting for PostgreSQL Compatibility#7
Merged
tianzhou merged 1 commit intopgplex:mainfrom Sep 6, 2025
Merged
Conversation
- Add intelligent quoting for reserved words and mixed-case identifiers - Preserve CamelCase for Better Auth, Prisma, Drizzle compatibility - Quote PostgreSQL reserved words (user, order, group, etc.) - Add comprehensive tests for quoting logic - Backwards compatible - only quotes when necessary Fixes compatibility with Better Auth, Supabase Auth, Lucia Auth, Prisma, Drizzle, TypeORM
tianzhou
approved these changes
Sep 6, 2025
Contributor
tianzhou
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the PR!
tianzhou
added a commit
that referenced
this pull request
Sep 6, 2025
column conditional quotation #7
tianzhou
added a commit
that referenced
this pull request
Sep 6, 2025
column conditional quotation #7
screenfluent
added a commit
to screenfluent/pgschema
that referenced
this pull request
Sep 6, 2025
- Quote column names in UNIQUE, PRIMARY KEY, and FOREIGN KEY constraints - Quote referenced table names in FOREIGN KEY constraints - Add tests for constraint quoting with camelCase and reserved words - Fixes issue where constraints with camelCase columns would fail This completes the identifier quoting feature by covering constraints that were missed in the initial PR pgplex#7.
tianzhou
pushed a commit
that referenced
this pull request
Sep 6, 2025
- Quote column names in UNIQUE, PRIMARY KEY, and FOREIGN KEY constraints - Quote referenced table names in FOREIGN KEY constraints - Add tests for constraint quoting with camelCase and reserved words - Fixes issue where constraints with camelCase columns would fail This completes the identifier quoting feature by covering constraints that were missed in the initial PR #7.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Smart Identifier Quoting for PostgreSQL Compatibility
Problem
pgschema currently strips quotes from identifiers, causing issues with:
user,order,group)userId,createdAt)PostgreSQL lowercases unquoted identifiers, so
userIdbecomesuserid, breaking compatibility with libraries expecting exact case.Solution
This PR adds intelligent identifier quoting that preserves quotes when needed:
Changes
identifier_quote.gowith quoting logicgetTableNameWithSchema()andqualifyEntityName()to use quotingImpact
Example
Before:
After:
Testing
Fixes compatibility with: Better Auth, Supabase Auth, Lucia Auth, Prisma, Drizzle, TypeORM