Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for COMMENT statements on materialized views by implementing parser functionality to handle OBJECT_MATVIEW object types and includes test data demonstrating materialized view comments in action.
- Added parser support for
COMMENT ON MATERIALIZED VIEWstatements in theparseCommentmethod - Created test materialized views with comments and associated indexes
- Updated test data to include materialized view inclusions and expected schema outputs
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| ir/parser.go | Implements parsing logic for materialized view comments by handling OBJECT_MATVIEW case |
| testdata/include/materialized_views/user_order_summary.sql | Adds test materialized view with aggregated user statistics and comment |
| testdata/include/materialized_views/monthly_stats.sql | Adds test materialized view with monthly order statistics and comment |
| testdata/include/main.sql | Includes the new materialized view files in the test schema |
| testdata/include/expected_full_schema.sql | Updates expected output to include the materialized views and their comments |
Comments suppressed due to low confidence (1)
testdata/include/expected_full_schema.sql:1
- The COMMENT statement for user_order_summary is missing from the expected schema output. This comment should appear after line 250 to match the source file structure.
-- Main schema file demonstrating \i include functionality
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
f18502e to
e957acb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.