Skip to content

Fix typo in boolean condition #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 9, 2025
Merged

Fix typo in boolean condition #79

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2db3e3c
Update query.c
bovlb Aug 9, 2025
272274f
add missing tests for 'IS NOT' clauses
mfenniak Aug 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/query.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -514,7 +514,7 @@ void extractClauseFromBooleanTest(Relids base_relids, BooleanTest *node, List **
break;
case IS_NOT_FALSE:
opname = "IS NOT";
val = (Expr *) makeConst(BOOLOID, -1, InvalidOid, sizeof(bool), BoolGetDatum(true), false, true);
val = (Expr *) makeConst(BOOLOID, -1, InvalidOid, sizeof(bool), BoolGetDatum(false), false, true);
break;
case IS_UNKNOWN:
opname = "IS";
Expand Down
14 changes: 14 additions & 0 deletions test-3.9/expected/multicorn_regression_test.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -519,6 +519,20 @@ NOTICE: ['test1', 'test2', 'test3']
-------+-------+-------
(0 rows)

select * from testmulticorn where test1 IS NOT TRUE;
NOTICE: [test1 IS NOT t]
NOTICE: ['test1', 'test2', 'test3']
test1 | test2 | test3
-------+-------+-------
(0 rows)

select * from testmulticorn where test1 IS NOT FALSE;
NOTICE: [test1 IS NOT f]
NOTICE: ['test1', 'test2', 'test3']
test1 | test2 | test3
-------+-------+-------
(0 rows)

select * from testmulticorn where test1 IS UNKNOWN;
NOTICE: [test1 IS None]
NOTICE: ['test1', 'test2', 'test3']
Expand Down
2 changes: 2 additions & 0 deletions test-3.9/sql/multicorn_regression_test.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,8 @@ select * from testmulticorn where test1 = TRUE;
select * from testmulticorn where test1 = FALSE;
select * from testmulticorn where test1 IS TRUE;
select * from testmulticorn where test1 IS FALSE;
select * from testmulticorn where test1 IS NOT TRUE;
select * from testmulticorn where test1 IS NOT FALSE;
select * from testmulticorn where test1 IS UNKNOWN;
select * from testmulticorn where test1 IS NOT UNKNOWN;

Expand Down