Skip to content

Fix jit_tests for register value cache optimization#21

Merged
pguyot merged 1 commit intojit-edgefrom
claude/cherry-pick-6b9cea8-WD8WF
Mar 2, 2026
Merged

Fix jit_tests for register value cache optimization#21
pguyot merged 1 commit intojit-edgefrom
claude/cherry-pick-6b9cea8-WD8WF

Conversation

@pguyot
Copy link
Owner

@pguyot pguyot commented Mar 2, 2026

These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).

SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later

Update term_to_int_verify_is_match_state_typed_optimization_x86_64_test
to reflect that the register value cache now eliminates the redundant
mov 0x68(%rdi),%rax after mov %rax,0x68(%rdi), since %rax already
holds the value. This was broken by ad33e7b ("JIT: fix register value
cache").
@coderabbitai
Copy link

coderabbitai bot commented Mar 2, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch claude/cherry-pick-6b9cea8-WD8WF

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pguyot pguyot merged commit 61b3548 into jit-edge Mar 2, 2026
44 of 193 checks passed
@pguyot pguyot deleted the claude/cherry-pick-6b9cea8-WD8WF branch March 2, 2026 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants