Added discord integration #376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niden
requested changes
Jun 25, 2017
| } | ||
| ); | ||
| } | ||
|
|
Contributor
Author
|
Okay fixes done, not sure about failing test, seems no related really. It was passing already this test so maybe rerun it in travis? Oh i see i can do it myself. |
Contributor
Author
|
Anyone have anything more to add? @sergeyklay @niden ? Maybe i should add some tests to it? |
Member
|
Thanks Juri! |
Contributor
|
@Jurigag Could you please return back the |
Contributor
Contributor
|
@Jurigag Also can you update the Wiki |
sergeyklay
reviewed
Jun 26, 2017
Contributor
sergeyklay
left a comment
sergeyklay
left a comment
There was a problem hiding this comment.
@Jurigag Also cold you take a look at my comments
| */ | ||
| $this->getDI()->getShared('queue')->put($toNotify); | ||
| /** @var Beanstalk $queue */ | ||
| $queue = $this->getDI()->getShared('queue'); |
Contributor
There was a problem hiding this comment.
$queue = singleton('queue');| $queue = $this->getDI()->getShared('queue'); | ||
| $queue->choose('notifications'); | ||
| /** @var DiscordComponent $discord */ | ||
| $discord = $this->getDI()->getShared('discord'); |
Contributor
There was a problem hiding this comment.
$discord = singleton('discord');| */ | ||
| $this->getDI()->getShared('queue')->put($toNotify); | ||
| /** @var Beanstalk $queue */ | ||
| $queue = $this->getDI()->getShared('queue'); |
Contributor
There was a problem hiding this comment.
$queue = singleton('queue');| $history->save(); | ||
| if ($this->hasUpdated('accepted') && $this->accepted == 'Y') { | ||
| /** @var DiscordComponent $discord */ | ||
| $discord = $this->getDI()->getShared('discord'); |
Contributor
There was a problem hiding this comment.
$discord = singleton('discord');| $queue->choose('notifications'); | ||
| $queue->put($toNotify); | ||
| /** @var DiscordComponent $discord */ | ||
| $discord = $this->getDI()->getShared('discord'); |
Contributor
There was a problem hiding this comment.
$discord = singleton('discord');| function () { | ||
| $config = container('config')->discord; | ||
|
|
||
| return new DiscordComponent($config); |
Contributor
There was a problem hiding this comment.
DiscordService. ServiceProvider not ComponentProvider right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was
composer.lockfile added to git, idk why exactly. I removed it because it shouldn't be on repo.