Add new assets filter instead default #523
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergeyklay
suggested changes
May 18, 2018
CHANGELOG.md
Outdated
| ### Added | ||
| - Added `AWS SQS` instead `beanstalk` | ||
| - Added `queue service` and method that generate queue name | ||
| - Added `Phosphorum\Assets\Filters\CssJsFilter`. `Phalcon\Assets\Filters\Jsmin` and `Phalcon\Assets\Filters\Cssmin` don't work in `rpm` package |
Contributor
There was a problem hiding this comment.
Added Phosphorum\Assets\Filters\NoneFilter to correct join unminified assets
| * Phosphorum\Assets\Filters\CssJsFilter | ||
| * @package Phosphorum\Assets\Filters | ||
| */ | ||
| class CssJsFilter implements FilterInterface |
| use Phalcon\Assets\FilterInterface; | ||
|
|
||
| /** | ||
| * Phosphorum\Assets\Filters\CssJsFilter |
| */ | ||
| public function filter($contents) | ||
| { | ||
| return $contents; |
Contributor
There was a problem hiding this comment.
return (string) $contents;
sergeysviridenko
force-pushed
the
3.5.x_add_filter_collection
branch
from
b36af7d to
88852e9
Compare
sergeyklay
approved these changes
May 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
In raising this pull request, I confirm the following:
Small description of change:
Add new assets filter instead default. Because default js and css filters don't work in
rpmpackageThanks