Skip to content

Reworked the constants/enums#74

Merged
niden merged 4 commits intophalcon:masterfrom
niden-code:master
Apr 16, 2026
Merged

Reworked the constants/enums#74
niden merged 4 commits intophalcon:masterfrom
niden-code:master

Conversation

@niden
Copy link
Copy Markdown
Member

@niden niden commented Apr 16, 2026

Removed duplication in constants and moved everything to specific enums

@niden niden requested a review from Jeckerson April 16, 2026 12:33
@niden niden self-assigned this Apr 16, 2026
@niden niden added the enhancement New feature or request label Apr 16, 2026
@niden niden added this to Phalcon v6 Apr 16, 2026
@github-project-automation github-project-automation bot moved this to In progress in Phalcon v6 Apr 16, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 16, 2026

Codecov Report

❌ Patch coverage is 96.46643% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.20%. Comparing base (ecf0409) to head (d7a08d1).
⚠️ Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
src/Compiler.php 93.42% 5 Missing ⚠️
src/Scanner/Scanner.php 96.36% 4 Missing ⚠️
src/Parser/Parser.php 98.95% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #74      +/-   ##
============================================
+ Coverage     86.17%   86.20%   +0.03%     
  Complexity     4484     4484              
============================================
  Files             9        9              
  Lines          6495     6517      +22     
============================================
+ Hits           5597     5618      +21     
- Misses          898      899       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@niden niden merged commit f1d8138 into phalcon:master Apr 16, 2026
13 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Implemented in Phalcon v6 Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Implemented

Development

Successfully merging this pull request may close these issues.

2 participants