Fix stdClass shape leakage across unrelated scopes#5477
Closed
SergioChan wants to merge 1 commit intophan:v6from
Closed
Fix stdClass shape leakage across unrelated scopes#5477SergioChan wants to merge 1 commit intophan:v6from
SergioChan wants to merge 1 commit intophan:v6from
Conversation
rlerdorf
added a commit
that referenced
this pull request
Mar 11, 2026
Member
|
Fixed in #5486 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AST_VARreads ininferStdClassShapePropertyType()when the local variable exists5918_stdclass_shape_scope_isolation.phpfor issue Phan incorrectly infers property type of newly created stdClass based on other assignments of properties on non-related stdClass instances #4789 so unrelated stdClass writes do not affect a fresh object's property typeTesting
php -v(fails in this environment:php: command not found, so Phan tests could not be executed here)@phan-debug-var $varresolves tostringRelated
Fixes #4789