-
Notifications
You must be signed in to change notification settings - Fork 1
Report #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report #4
Conversation
|
This reports works but there are some corner cases to fix:
|
|
Template report can be rendered correctly, on both windows and ubuntu. Could I edit the documentation directly? The assessment function is designed to process an object created by the pkg_assess() function from the riskmetric package. The function takes this assessment object and converts it into a simplified data.frame without scoring the assessment. The function ensures that the input is of the correct type and processes specific elements using the risk_error function. I cannot generate the vignettes on my local machine due to this line: Some other suggestions:
|
|
Yes, feel free to commit and push to the branch! I took too much shortcuts and neglected a bit the documentation. I haven't tested building the package or generating vignettes as some of them assume certain data or took too long (until I discovered that riskmetric was checking the package again) . Would you like to work on that?
|
Not sure about this vignettes, I will see what I can do.
Yes, one general for all packages, one for individual report (maybe also for a filtered list of packages based on the previous one) where the user can have more control on what criteria are used, what should be included in the report. I do have time on Monday, but I am not so good at coding and not sure how much I can contribute there. I feel we can merge the pull request and work on these afterwards, then create a new pull request. |
Creating the report, takes the template from insightsengineering/thevalidatoR
Closes #2