Refactor: replace isNilNode with polymorphic#43
Merged
jordanmontt merged 1 commit intopharo-containers:mainfrom Mar 10, 2026
Merged
Refactor: replace isNilNode with polymorphic#43jordanmontt merged 1 commit intopharo-containers:mainfrom
jordanmontt merged 1 commit intopharo-containers:mainfrom
Conversation
Member
|
Yes, great work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the Null Object Pattern implementation that we talked about in #40.
Instead of manually checking
isNilNodeeverywhere, the code now relies on proper polymorphism:CTAVLNode >> children: Now filters valid children usingisEmptyinstead of checking for nil.CTAVLTree >> allChildren: Removed the manual left/right nil checks during BFS.CTAVLNode >> postCopy: RemovedisNilNodechecks sincecopyon a nil node safely returns a new nil node anyway.isNilNodefrom the node classes entirely since there are no senders left.All tests are green!

Let me know if everything looks good