Allow Cogit>>#mnuMethodOrNilFor: to return non-CompiledMethod oops

[iglosiggio]

This should fix #935. The origin of this issue appears to be from a partially applied fix (previously we tried to compile method wrappers, then we just skipped them. Now we don't try to compile them but we properly return them as valid "methods" (given that we have the #run:with:in semantics for method invocation of regular objects).

See #578 for more info.

[iglosiggio]

Looking at the previous change (#578) this PR may break some tests. I'm not convinced those tests are correct though.

[guillep]

Looking at the previous change (#578) this PR may break some tests. I'm not convinced those tests are correct though.

indeed there is one broken test (failing in four different configs):

https://ci.inria.fr/pharo-ci-jenkins2/job/pharo-vm/job/PR-936/1/testReport/junit/MacOSX64.VMMakerTests/VMJittedLookupTest/VM_Unit_Tests___testLookUpMNUWithAnyNonMethodObjectShouldNotJItCompile__ISA___aarch64__wordSize__8__useComposedImageFormat__true_/

pharo-vm/PR-936 #1 test - VM Unit Tests / testLookUpMNUWithAnyNonMethodObjectShouldNotJItCompile(#ISA->#aarch64 #wordSize->8 #useComposedImageFormat->true) [Jenkins]

[iglosiggio]

indeed there is one broken test (failing in four different configs):

Exactly, I think the new behavior is correct. The test is trying to check that the method was not compiled, if it was not a method. There's no way to check that a non-method was not compiled because only methods should be compiled. What the test tries to assert is not expressable as a valid idea.

Maybe it is enough to assert that the lookup result is not a compiled method and that the counter for compiled methods was kept at a constant value before/after the lookup. I'm not sure tbh.

[iglosiggio]

Should be fixed now :)

[guillep]

Thanks @iglosiggio mega for the great energy :)