Skip to content

Conversation

@Ducasse
Copy link
Collaborator

@Ducasse Ducasse commented Nov 8, 2025

  • some automated repair
  • fix the fetchAllRemotes DNU

@Ducasse
Copy link
Collaborator Author

Ducasse commented Nov 8, 2025

ceberg-SmartUI not found
Iceberg-Pharo6 not found
Instance of MetacelloPlatform did not understand #withMetacelloLoadSessionDo:
MetacelloPlatform(Object)>>doesNotUnderstand: #withMetacelloLoadSessionDo:
MetacelloScriptApiExecutor>>execute
Metacello>>execu

@jecisc
Copy link
Contributor

jecisc commented Nov 9, 2025

The application has #informUser:during:

Maybe we should add an #informUserDuring: also letting the developper manage the label himself instead of providing a default label?

So first step is to add informUserDuring: in Spec then use it here

@jecisc
Copy link
Contributor

jecisc commented Nov 9, 2025

Hum... In fact we can directly use #informUser:during: I think. I'll propose a code update to fix the problem

Copy link
Contributor

@jecisc jecisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I proposed a fix that should work I hope

Comment on lines +67 to 71
self halt. "We should not use UIManager default.
Now the replacement is not clear to me. SD."
UIManager default informUserDuring: [ :bar |
bar label: 'Fetching incoming commits'.
bar max: remotes size.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
self halt. "We should not use UIManager default.
Now the replacement is not clear to me. SD."
UIManager default informUserDuring: [ :bar |
bar label: 'Fetching incoming commits'.
bar max: remotes size.
self application informUser: 'Fetching incoming commits' during: [ :bar |
bar max: remotes size.

@jecisc
Copy link
Contributor

jecisc commented Nov 9, 2025

I also did a PR to fix some of the CI's failures: #1990

@Ducasse Ducasse merged commit 479956b into pharo-vcs:Pharo14 Nov 9, 2025
0 of 3 checks passed
@Ducasse
Copy link
Collaborator Author

Ducasse commented Nov 9, 2025

Tx cyril. I found the fix for the unclosing tabs :) My mistake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants