-
Notifications
You must be signed in to change notification settings - Fork 92
Fixing the fetchAllRemotes DNU #1989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Ducasse
commented
Nov 8, 2025
- some automated repair
- fix the fetchAllRemotes DNU
|
|
The application has #informUser:during: Maybe we should add an #informUserDuring: also letting the developper manage the label himself instead of providing a default label? So first step is to add informUserDuring: in Spec then use it here |
|
Hum... In fact we can directly use #informUser:during: I think. I'll propose a code update to fix the problem |
jecisc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I proposed a fix that should work I hope
| self halt. "We should not use UIManager default. | ||
| Now the replacement is not clear to me. SD." | ||
| UIManager default informUserDuring: [ :bar | | ||
| bar label: 'Fetching incoming commits'. | ||
| bar max: remotes size. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| self halt. "We should not use UIManager default. | |
| Now the replacement is not clear to me. SD." | |
| UIManager default informUserDuring: [ :bar | | |
| bar label: 'Fetching incoming commits'. | |
| bar max: remotes size. | |
| self application informUser: 'Fetching incoming commits' during: [ :bar | | |
| bar max: remotes size. |
|
I also did a PR to fix some of the CI's failures: #1990 |
|
Tx cyril. I found the fix for the unclosing tabs :) My mistake. |