Skip to content

Conversation

@grayside
Copy link
Contributor

@grayside grayside commented Oct 4, 2014

  • Adds phpcs as currently constituted as a validate task.
  • Adds phpcs:validate as an operation to the validate task. Defaults to "summary" but can be overridden in config. Displays results in terminal.
  • Retains phpcs:drupal for backwards compatibility.
  • Adds phpcs:inspect for more detailed reporting with the "full" format.
  • For reasons of code-flow & variable scope, recombines the analyze & validate files as "quality.js".

This fixes #1

I wanted to handle #18 as well, but using the ruleset as defined by the Coder module the granularity of errors is very flat, hence the addition of the "inspect" target for deeper reporting. I imagine we'll want to use inspect for a watch variant, but leaving that for #13.

@grayside
Copy link
Contributor Author

grayside commented Oct 4, 2014

After further consideration, renamed inspect to full for more intuitive naming, added gitblame and summary as explicit options.

@grayside
Copy link
Contributor Author

I'll spend some time fixing conflicts after some positive feedback. @arithmetric, think this is good to go?

grayside added a commit that referenced this pull request Oct 23, 2014
Add phpcs to analyze, display inline results on validate.
@grayside grayside merged commit 5b53c47 into master Oct 23, 2014
@arithmetric arithmetric deleted the phpcs-analyze branch November 23, 2014 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PHPCS should output to terminal on validate, generate report on analyze

2 participants