Skip to content

Conversation

@grayside
Copy link
Contributor

This is based off of #7. Please review/merge that first.

This adds a new top-level section to the README for contribution instructions. I don't have a clear sense that we have coding standards or process on this project to any great extent, so it focuses on explaining how to think about certain types of contributions.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so this doesn't work if you want to extend or modify the current steps in the existing tasks. you have to use grunt-extend-config and then only do it within the gruntfile.js. i've tried it separate tasks and it seems extendConfig doesn't recognize includes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modifying the existing tasks in your project would be in Customizing, not Contributing :)

That said, you should be able to just use grunt.config.set() to override whatever configuration we've got in the system, the trick is making sure API calls like that come later in the bootstrapping process of all the code. The configuration is all assembled before tasks are run. We should talk about what you are trying to do, maybe there are changes to be made to more naturally support it?

@grayside grayside modified the milestone: 0.3.0 Sep 22, 2014
@grayside
Copy link
Contributor Author

Been a few days, not seeing objections. Swabbing the deck.

grayside added a commit that referenced this pull request Sep 25, 2014
Added a CONTRIBUTING section to the README
@grayside grayside merged commit 78556f6 into master Sep 25, 2014
@arithmetric arithmetric deleted the docs/contributing branch October 26, 2014 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants