Skip to content

Updating the url to use https and version bump.#12

Merged
EvanLovely merged 1 commit intophase2:masterfrom
robbiethegeek:master
Apr 30, 2016
Merged

Updating the url to use https and version bump.#12
EvanLovely merged 1 commit intophase2:masterfrom
robbiethegeek:master

Conversation

@robbiethegeek
Copy link
Copy Markdown
Contributor

No description provided.

@robbiethegeek
Copy link
Copy Markdown
Contributor Author

@EvanLovely @illepic @smerrill can you guys take a look / merge. Seems like there is an issue with defaulting to ssh and having no credentials within docker containers initially. @smerrill and I looked at this on Saturday at the Drupal NYC Playday

@robbiethegeek
Copy link
Copy Markdown
Contributor Author

bump...

@EvanLovely EvanLovely merged commit 3951cf0 into phase2:master Apr 30, 2016
@EvanLovely
Copy link
Copy Markdown
Contributor

@robbiethegeek I merged this in and closed out the other bad PR #11. Thanks for getting this in! Was curious if the GitHub shorthand in package.json could work here and might of provided the sensible defaults:

"dependencies": {
  "workshopper-jlord": "jlord/workshopper"
}

Anyway, I tested before merging with no errors (as I have ssh setup and GitHub creds), so I'm not able to test this fix; mind checking? Thanks! 🍻

@robbiethegeek
Copy link
Copy Markdown
Contributor Author

@EvanLovely I was able to reproduce the error by trying to install from within a newly created docker container without passing through my ssh keys. It might work would you like to me to test or are you ok with this for now?

EvanLovely added a commit that referenced this pull request Apr 30, 2016
@EvanLovely
Copy link
Copy Markdown
Contributor

@robbiethegeek ok, check this out again. See above commits.

@robbiethegeek
Copy link
Copy Markdown
Contributor Author

👍 LGTM

@EvanLovely
Copy link
Copy Markdown
Contributor

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants