Skip to content

Feature - Add sounds (and associated bug fixes)#94

Merged
Tapawingo merged 43 commits intomainfrom
feature/sounds
Dec 13, 2025
Merged

Feature - Add sounds (and associated bug fixes)#94
Tapawingo merged 43 commits intomainfrom
feature/sounds

Conversation

@Tapawingo
Copy link
Copy Markdown
Contributor

@Tapawingo Tapawingo commented Nov 30, 2025

When merged this pull request will:

  • Fix cloud render
  • Fix skyshader
  • Add environment soundcontroller
  • Add environment sounds for day/night ambience, rain light/heavy and wind light/heavy
  • Fix broken environment scene loader
  • Add UI select/hover sounds
  • Add Situational SFX (artillery outgoing/impacts and combat sounds)
  • Add more visual weather effects (rain/fog/wind)
  • Consolidate all radio related scripts into radio.tscn (UnitVoiceResponses, UnitAutoResponses)
  • Fix issues with unit auto responses
  • Make unit responses config data file
  • Add Radio SFX sounds
  • Fix issue of double acknowledgement for FIRE orders
  • Fix wind direction
  • Fix callsign issues with ammo and fuel reports
  • Add Collision sounds to physics items
  • Add sounds to page changes on documents
  • Fix drawing mesh offset
  • Fix engineer ammo consumption
  • Fix ammunition values not loading when editing a unit
  • Add unit responses for resupply (refuelling unit, resupplying unit)
  • Refactor radio subtitles to be more configurable and add missing suggestions
  • Add Audio input/playback device settings
  • Add menu music

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code.
  • I have tested my code.
  • I have documented my code in accordance with gdscript_documentation_comments.
  • I have requested a review in discord.
  • I have moved the related issues to the review section in the SCRUM Board.

@Tapawingo Tapawingo mentioned this pull request Dec 4, 2025
5 tasks
@Tapawingo
Copy link
Copy Markdown
Contributor Author

Merge conflict has been resolved

@GianRathgeb
Copy link
Copy Markdown
Contributor

music or sounds a bit loud in the intro, especially at the end
the hover sound with mouse over a button is a bit too long for my taste and should be a bit more silent
game is really laggy on my notebook, unplayable, can you get some performence out of the sounds before I implement the other performance changes?

@Tapawingo
Copy link
Copy Markdown
Contributor Author

music or sounds a bit loud in the intro, especially at the end the hover sound with mouse over a button is a bit too long for my taste and should be a bit more silent game is really laggy on my notebook, unplayable, can you get some performence out of the sounds before I implement the other performance changes?

I've made the requested changes (although they might still be too loud) and did some rather huge optimizations for hopefully better performance.

@GianRathgeb
Copy link
Copy Markdown
Contributor

The sounds are now way better, this part is approved.
The game is still very laggy on my notebook. This could also just be a problem on my side.
I think we can merge this and since I am working on improving performance in other parts of the game, I can also look into this.
So I would approve this, just make sure it is not laggy on your side before mergin.

@Tapawingo Tapawingo merged commit 1285ca0 into main Dec 13, 2025
3 checks passed
@Tapawingo Tapawingo deleted the feature/sounds branch December 13, 2025 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants