Secret Referencing Fails Within Syncs

[m-braha]

Describe the bug

Secret referencing doesn't seem to work when using GitHub Syncing.

Assume there is a Phase app "Shared" and another one "Web". If the "Web" app has a secret reference to a secret in the "Shared" app, when the GitHub sync runs, the following error is shown:

The sync fails with "The referenced key Shared::KEY does not exist in the Development environment."

If using phase secrets export from the command line, all references resolve cleanly indicating the reference syntax is correct.

To Reproduce

Steps to reproduce the behavior:

1. Create two apps.
2. Have one secret in the app reference a secret in the other app
3. Configure GitHub sync as normal
4. Try to sync
5. Observe error

Expected behavior

A clear and concise description of what you expected to happen.

Screenshots

If applicable, add screenshots to help explain your problem.

Platform you are having the issue on:

Additional context

We don't know if it's GitHub-specific sync issue or if this affects all syncs.

[rohan-chaturvedi]

Hey @m-braha , this seems like its actually a bug with the CLI. The reference string Shared::KEY is technically invalid, since it doesn't specify the Environment. The correct reference syntax would include the env: Shared::development.KEY.

It seems the CLI is currently inferring the the environment implicitly based on the environment where the reference is defined, but this breaks if the environments are different. For example in your setup, this would fail:

#Shared development
KEY=FOO

# Web staging
KEY=${Shared::KEY}

I'm moving this issue to the CLI, and we'll patch this to require the environment to be explicitly defined.