Skip to content

fix: prevent org names from being reformatted with startCase #672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 31, 2025
Merged

fix: prevent org names from being reformatted with startCase #672

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a51c6c8
fix: prevent org names from being reformatted
rohan-chaturvedi Oct 30, 2025
718080b
fix: remove redundant breadcrumbs
rohan-chaturvedi Oct 30, 2025
52e2b37
fix: improve title generation by filtering empty labels and applying …
rohan-chaturvedi Oct 30, 2025
aa32664
Merge branch 'main' into fix--breadcrumb-org-name-formatting
rohan-chaturvedi Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions frontend/components/layout/Navbar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,11 +76,11 @@ export const NavBar = () => {
href={crumb.href}
className="capitalize overflow-hidden text-ellipsis whitespace-nowrap text-zinc-500"
>
{startCase(crumb.label)}
{crumb.label}
</Link>
) : (
<span className="capitalize text-zinc-900 dark:text-zinc-100 overflow-hidden text-ellipsis whitespace-nowrap">
{startCase(crumb.label)}
{crumb.label}
</span>
)}
</div>
Expand Down
14 changes: 10 additions & 4 deletions frontend/utils/navigation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,10 +124,16 @@ export const generateBreadcrumbs = (ctx: NavigationContext): NavigationItem[] =>
export const generatePageTitle = (ctx: NavigationContext): string => {
const breadcrumbs = generateBreadcrumbs(ctx)

// Filter out empty labels and reverse for title (most specific first)
const titleParts = breadcrumbs
.filter((crumb) => crumb.label && crumb.label.trim())
.map((crumb) => startCase(crumb.label))
const filteredCrumbs = breadcrumbs.filter((crumb) => crumb.label && crumb.label.trim())

// Apply startCase to all except the first breadcrumb (team/org name)
const titleParts = filteredCrumbs
.map((crumb, index) => {
if (index === 0 && ctx.team) {
return crumb.label
}
return startCase(crumb.label)
})
Copy link

@cursor cursor bot Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Breadcrumb Title Formatting Issue

The generatePageTitle function's logic to skip startCase for the first breadcrumb assumes it's always an organization name. This causes incorrect title formatting for non-team routes (e.g., "Sign Up") and when earlier breadcrumbs are filtered, leading to app names not being properly startCased.

Fix in Cursor Fix in Web

.reverse()

if (titleParts.length === 0) {
Expand Down