Skip to content

fix: stale app access cache #796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nimish-ks merged 3 commits into from
Mar 9, 2026
Merged

fix: stale app access cache #796

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7ac62fb
fix: refetch app access when adding or removing member from app
rohan-chaturvedi Mar 7, 2026
6f7a205
fix: refetch app access for service accounts
rohan-chaturvedi Mar 7, 2026
319a826
Merge branch 'main' into fix--app-access-cache
rohan-chaturvedi Mar 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions frontend/app/[team]/apps/[app]/access/members/_components/AddMemberDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,6 +227,10 @@ export const AddMemberDialog = ({ appId }: { appId: string }) => {
query: GetAppMembers,
variables: { appId: appId },
},
...selectedMembers.map((m) => ({
query: GetAppEnvironments,
variables: { appId: appId, memberId: m.id },
})),
],
})

Expand Down
5 changes: 5 additions & 0 deletions frontend/app/[team]/apps/[app]/access/members/_components/RemoveMemberDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import RemoveMemberFromApp from '@/graphql/mutations/apps/removeAppMember.gql'
import GetAppMembers from '@/graphql/queries/apps/getAppMembers.gql'
import { GetAppEnvironments } from '@/graphql/queries/secrets/getAppEnvironments.gql'
import { useMutation } from '@apollo/client'
import { Fragment, useRef, useState } from 'react'
import { OrganisationMemberType } from '@/apollo/graphql'
Expand Down Expand Up @@ -32,6 +33,10 @@ export const RemoveMemberConfirmDialog = ({
query: GetAppMembers,
variables: { appId: appId },
},
{
query: GetAppEnvironments,
variables: { appId: appId, memberId: member.id },
},
],
})
toast.success('Removed member from app', { autoClose: 2000 })
Expand Down
4 changes: 4 additions & 0 deletions frontend/app/[team]/apps/[app]/access/service-accounts/_components/AddAccountDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,10 @@ export const AddAccountDialog = ({ appId }: { appId: string }) => {
query: GetAppServiceAccounts,
variables: { appId: appId },
},
...selectedAccounts.map((a) => ({
query: GetAppEnvironments,
variables: { appId: appId, memberId: a.id, memberType: MemberType.Service },
})),
],
})

Expand Down
5 changes: 5 additions & 0 deletions frontend/app/[team]/apps/[app]/access/service-accounts/_components/RemoveAccountDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import RemoveMemberFromApp from '@/graphql/mutations/apps/removeAppMember.gql'
import { GetAppServiceAccounts } from '@/graphql/queries/apps/getAppServiceAccounts.gql'
import { GetAppEnvironments } from '@/graphql/queries/secrets/getAppEnvironments.gql'
import { useMutation } from '@apollo/client'
import { useRef } from 'react'
import { ServiceAccountType, MemberType } from '@/apollo/graphql'
Expand Down Expand Up @@ -32,6 +33,10 @@ export const RemoveAccountConfirmDialog = ({
query: GetAppServiceAccounts,
variables: { appId: appId },
},
{
query: GetAppEnvironments,
variables: { appId: appId, memberId: account.id, memberType: MemberType.Service },
},
],
})
toast.success('Removed member from app', { autoClose: 2000 })
Expand Down