Skip to content

feat: improve secret sorting#826

Merged
nimish-ks merged 1 commit intomainfrom
feat--improve-secret-sorting
Mar 26, 2026
Merged

feat: improve secret sorting#826
nimish-ks merged 1 commit intomainfrom
feat--improve-secret-sorting

Conversation

@rohan-chaturvedi
Copy link
Copy Markdown
Member

@rohan-chaturvedi rohan-chaturvedi commented Mar 25, 2026

Summary

  • Add sort menu to the cross-environment secrets editor, matching the existing single-env editor UX
  • Persist sort selection in localStorage so it survives page reloads and navigation across both editors
  • Make sort menu typography responsive (text-2xs on narrow screens, text-sm on 2xl+) to match input styles

Changes

  • frontend/utils/secrets.ts: Add getSavedSort/saveSort helpers for localStorage persistence, and sortAppSecrets for sorting AppSecret[] in the cross-env editor
  • frontend/app/[team]/apps/[app]/_components/AppSecrets.tsx: Wire up SortMenu component with localStorage-backed sort state, wrap filtered secrets in useMemo with sort applied
  • frontend/app/[team]/apps/[app]/environments/[environment]/[[...path]]/page.tsx: Use getSavedSort/saveSort to persist sort selection
  • frontend/components/environments/secrets/SortMenu.tsx: Update typography to text-2xs 2xl:text-sm for responsive sizing

Test plan

  • Open single-env editor, change sort order, reload page — sort should persist
  • Open cross-env editor — same sort selection should be applied
  • Change sort in cross-env editor, navigate to single-env editor — selection should carry over
  • On narrow viewport, verify sort menu text matches search input sizing

Signed-off-by: rohan <rohan.chaturvedi@protonmail.com>
@rohan-chaturvedi rohan-chaturvedi added enhancement New feature or request frontend Change in frontend code labels Mar 25, 2026
@nimish-ks nimish-ks merged commit cd98550 into main Mar 26, 2026
7 checks passed
@nimish-ks nimish-ks deleted the feat--improve-secret-sorting branch March 26, 2026 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request frontend Change in frontend code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants