fix: use correct enum type in SecretPropertyDiffs#836
Merged
Conversation
6 tasks
The committed schema.graphql was stale — the backend generates ApiSecretEventTypeChoices for SecretEventType.type but the committed schema had ApiSecretTypeChoices. This caused CI to fail because codegen in Docker produced a different type than what the frontend code expected. Regenerated schema from backend and updated SecretPropertyDiffs to use ApiSecretEventTypeChoices.
nimish-ks
force-pushed
the
fix/secret-property-diffs-type-error
branch
from
52644e9 to
04c2802
Compare
rohan-chaturvedi
approved these changes
Mar 29, 2026
rohan-chaturvedi
approved these changes
Mar 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SecretPropertyDiffs.tsxwas comparinghistoryItem.type(typed asApiSecretEventTypeChoices) againstApiSecretTypeChoices, which TypeScript flags as having no type overlapApiSecretEventTypeChoicessince the component operates onSecretEventTypeobjectsTest plan