Skip to content

Conversation

@nimish-ks
Copy link
Member

Description

This PR addresses a bug in our Kubernetes operator related to secret referencing. The fix ensures that the operator correctly handles and resolves secret references within Kubernetes resources.

Changes

  • Modified the secret resolution logic in the operator to correctly handle local path references.

To test this change:

  1. Deploy the updated operator to a test Kubernetes cluster.
  2. Create a local secret reference across a path in Phase (e.g., ${/path/to/SECRET}).
  3. Deploy that application via the Phase Kubernetes custom CR.
  4. Fetch the secret via kubctl and base64 decode it and verify the secret reference.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jul 28, 2024

Deploying helm-repo-kubernetes-secrets-operator with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2653097
Status: ✅  Deploy successful!
Preview URL: https://ec7ac0b3.helm-repo-kubernetes-secrets-operator.pages.dev
Branch Preview URL: https://fix--secret-reference-1.helm-repo-kubernetes-secrets-operator.pages.dev

View logs

@nimish-ks nimish-ks merged commit c7e169f into main Jul 29, 2024
@nimish-ks nimish-ks deleted the fix--secret-reference-1 branch July 29, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants