example repo fails with 404; turn backslash into slashes to fix it #318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the provided repo when served directly. Otherwise, for instance, going to http://localhost/phaser3-examples/public/boot.html?src=src\camera\multi%20camera\boot.json attempts to access http://localhost/phaser3-examples/public/Controller.js?_=1597765543353 instead of http://localhost/phaser3-examples/public/src/camera/multi%20camera/Controller.js?_=1597765624222 resulting in a 404. The code in index.html appears to use slashes. Tested on Linux/nginx/Firefox via localhost
This was referenced Aug 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example repo, when cloned into the server folder of nginx, fails to work via localhost on Ubuntu/Linux.
For instance, going to
http://localhost/phaser3-examples/public/boot.html?src=src\camera\multi%20camera\boot.json
attempts to access http://localhost/phaser3-examples/public/Controller.js?_=1597765543353
instead of http://localhost/phaser3-examples/public/src/camera/multi%20camera/Controller.js?_=1597765624222
resulting in a 404.
This patch fixes the provided repo when served directly in this way. The code in index.html appears to use slashes.
Tested on Linux/nginx/Firefox via localhost (not tested on Windows).
I do not know what strategy for converting slashes/backslashes is being used.