Fix for bug #906#912
Merged
photonstorm merged 6 commits intophaserjs:devfrom Jul 1, 2014
j0hnskot:onDecoded-patch
Merged
Conversation
Collaborator
|
Thanks for this - I'm wondering if the Signal will be dispatched multiple times (as it's part of the update loop), rather than just once like it should. |
Contributor
Author
|
When i tested it i used addOnce. Probably without that the event will fire many times. But i think a simple variable to check if the event was fired will solve this since the onDecoded won't need to actually fire any other time except the first one. Want me to add it and make a new pull request? |
Contributor
Author
|
Fixed it and added a description to the boolean. |
Collaborator
|
Sweet - thank you :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the bug #906 by adding a check for isDecoded in the update loop.