Switch to the UnusedStateRemoval #833
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove all non-orthogonal convenience member functions (i.e.
functions reaching from lambda::node into lambda::operation).
Redudant helpers may save typing, but generally cause churn
during decoupling.
Extract memory state modelling from lambda node: The modelling
is quite specific to how llvm-level transformations represent functions
etc. Everything related to that modelling should probably be
consolidated into a location (i.e. the "memory encoding bits")
rather than being spread out to the pieces they apply to.
Move argument attributes to lambda operation: This removes the last
bit of state from the lambda node which now really only contains graph
structural information.
Moving the attributes also has the effect of subjecting them to implicit
copy, removing the need to manually copy them in various places.
|
phate
previously approved these changes
Mar 19, 2025
Collaborator
Author
|
@phate Made the suggested change, so need a new review. |
|
phate
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code for handling unused/invariant edges has been existing in duplicated versions. This PR switches over to the newer UnusedStateRemoval version.