(1) The final declaration may exclude a semicolon, i.e. the following is valid: @Property --rotation { syntax: "*"; inherits: false } (2) When the parser encounters a "propertyRuleInvalidDeclaration" production, it did not handle semicolons properly. When browser compliant mode is disabled, the error handler calls "errorSkipTo (ex, SEMICOLON)", which consumes the semicolon. But the "propertyRule" production then tries to consume a SEMICOLON, which fails. E.g. in the following example, the "inherits" descriptor was dropped due to a second parse error from the unexpected semicolon: @Property --rotation { syntax: "*"; color: red; inherits: false } (3) Invalid declarations must be ignored. There was a check for number of declarations <= 3, but that fails when there are additional invalid declarations. I.e. the following should still parse: @Property --rotation { syntax: "*"; inherits: false; color: red; initial-value: 45deg; } (4) When the parser encounters a propertyRuleInvalidDeclaration production and browser compliant mode is disabled, it output an "ERROR_SKIPTO" token. The CSSNodeToDomainObject converter did not account for tokens of that kind. I changed so it ignore such tokens, similar to how it is done for "CSSNodeToDomainObject#_readStyleDeclarationList". (5) CSSNodeToDomainObject#_createPropertyRuleDeclaration had its return type annotated with @nonnull, but returned "null" in various cases. Calling CSSPropertyRule#addPropertyRuleDeclaration then threw a NullPointerException when called with the returned null value. (6) The ParserCSS30#browserCompliantSkipDecl invokes "ICSSParseErrorHandler#onCSSBrowserCompliantSkip" with the "currentToken" from the parse exception. The method "onCSSBrowserCompliantSkip" has the token parameters annotated with @nonnull. But when we create a custom parse exception via "new ParseException(String)", the "currentToken" is null. There might be better ways, but for now I defaulted to the current "token" to prevent NPE. (7) When converting a property rule to a string, a semicolon must appear after each declaration, other than the last. I.e. the following output from CSSPropertyRule#getAsCSSString was invalid: @Property --rotation { syntax: "*" inherits: false } (8) When converting a property rule with only one declaration to a string with pretty-printing enabled, should not write newlines, to stay consistent for how it currently behaves with style rules, i.e. @Property --rotation { syntax: "*"; }

Support @property rule (CSS Houdini) #121

Description

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions