Add structural variants to Testimonial component#78
Conversation
Adds support for 'elevated', 'flat', 'outline', and 'ghost' variants to the Testimonial component. The default variant is 'outline' to maintain backward compatibility. - Updated 'src/recipes/testimonial.ts' with the new variant option. - Added corresponding CSS classes and role variables in 'src/styles/components.css'. - Synchronized 'tests/css-contract.test.ts' and 'tests/arsenal-sync.test.ts'. Co-authored-by: bradpotts <4887598+bradpotts@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThis PR introduces testimonial variant support to the Spectre UI component library. The change adds four variant options ( ChangesTestimonial Variant Feature
🎯 2 (Simple) | ⏱️ ~12 minutes
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Added structural variants (elevated, flat, outline, ghost) to the Testimonial component. This brings it in parity with the Card component and provides more flexibility in layout design while maintaining backward compatibility by defaulting to the 'outline' variant.
PR created automatically by Jules for task 17528705703208929091 started by @bradpotts
Summary by CodeRabbit
Release Notes
New Features
Tests