Add documentation for Quick Start Project #126
Merged
abose merged 6 commits intophcode-dev:mainfrom Oct 5, 2024
devvaannsh:main
Merged
Add documentation for Quick Start Project #126abose merged 6 commits intophcode-dev:mainfrom devvaannsh:main
abose merged 6 commits intophcode-dev:mainfrom
devvaannsh:main
Conversation
abose
reviewed
Oct 2, 2024
| // For GitHub pages deployment, it is often '/<projectName>/' | ||
| baseUrl: "/", | ||
| trailingSlash: true, | ||
| trailingSlash: false, |
Member
There was a problem hiding this comment.
Will this break links in the existing userbase? Eg: we have doc links with a / distributed in desktop apps, and those links may end up unreachable?
https://github.com/phcode-dev/phoenix/blob/main/src/assets/default-project/en/Newly_added_features.md?plain=1
Member
Author
There was a problem hiding this comment.
Yes, you're right. This change might break those links.
Member
|
LGTM. Thanks for contributing @devvaannsh Merging to test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does the following changes :-
For ex :- 'features/quickEdit' (is valid path), but because of the trailingSlash the file path became :-
'features/quickEdit/' (invalid path)
(04-Features/06-quick-edit.md) [previously]
(Features/quick-edit) [current]