fix: cursor not seen if line is empty and no git gutter marker in line in git projects #2070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e in git projects This was caused by fractional .7em rendering of git gutter. The css pixel approximation will hide the 1px cursor line in certain window widths, so we should not use fractional em in the gutter. if was to use a 1em gutter and set a fractional em inset border so that gutter width not fractional also added hover style so that when user hovers over 1em gutter, it expands to 2 em to have the user not work with needle threading precision to click git gutter. the green git-added-lines gutter will not expand as there is currently no action associated with it.
…detail pane in safari too
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was caused by fractional .7em rendering of git gutter. The css pixel approximation will hide
the 1px cursor line in certain window widths, so we should not use fractional em in the gutter.
if was to use a 1em gutter and set a fractional em inset border so that gutter width not fractional
also added hover style so that when user hovers over 1em gutter, it expands to 2 em to have
the user not work with needle threading precision to click git gutter. the green git-added-lines
gutter will not expand as there is currently no action associated with it.