Skip to content

TabBar Integration #2159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 35 commits into from
Mar 22, 2025
Merged

TabBar Integration #2159

merged 35 commits into from
Mar 22, 2025

Conversation

@devvaannsh
Copy link
Member

@devvaannsh devvaannsh commented Mar 3, 2025 •
edited
Loading

Screen.Recording.2025-03-16.171057.mp4

devvaannsh added 30 commits March 3, 2025 23:25
@devvaannsh
feat: tab bar working prototype
4b31e63
@devvaannsh
feat: add close button in tabs to remove the tab
f379975
@devvaannsh
fix: tab bar for both panes gets closed when one pane tab bar gets empty
62ac120
@devvaannsh
refactor: styling issues
7d82ae6
@devvaannsh
fix: tab bar not found in DOM when no files in pane
9447858
@devvaannsh
feat: add numberOfTabs preference feature
2738ae8
@devvaannsh
feat: add dirty icon if file is modified and show popup to save befor…
5749246 
…e closing
@devvaannsh
feat: add more option button in tab bar
0438625
@devvaannsh
feat: add dropdown in more-options
95d55ea
@devvaannsh
feat: handle close all tabs from more-options button
dcd0a33
@devvaannsh
feat: add reopen closed file in tab bar context menu
fd6086b
@devvaannsh
feat: replace more options button with tabs right click handler
6dda8f2
@devvaannsh
feat: create overflow button in tabbar
83b8f44
@devvaannsh
feat: scroll to active tab when tab is not visible
9a4f60d
@devvaannsh
feat: implement close and close active tab in more options context menu
74475b1
@devvaannsh
feat: add close button in overflow menu to work
302b856
@devvaannsh
feat: make dirty indicator work in overflow menu
c24efeb
@devvaannsh
feat: setup drag and drop for tab bar
e6f6e5e
@devvaannsh
fix: when sidebar gets resized the tabs get updated for correct overf…
7080809 
…low status
@devvaannsh
fix: udpate tab bar when live preview gets resized
90c48e2
@devvaannsh
fix: tab bar disappearing bug
cf8f718
@devvaannsh
fix: if both panes have same file, we open that file only on desired …
435d565 
…pane
@devvaannsh
chore: improve styling
ed2ff74
@devvaannsh
fix: tab bar disappearing when only one file is added in split view case
05f6aed
@devvaannsh
fix: tab bar not appearing when opening image file
71cdd2b
@devvaannsh
chore: improve styling
233f29a
@devvaannsh
feat: implement close unmodified tabs feature
12001d5
@devvaannsh
chore: make tab bar style compatible for light theme
c601e61
@devvaannsh
fix: unit tests failing issue
fd6bd12
@devvaannsh
fix: integ tests failing
344dfad
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 21, 2025

Quality Gate Passed Quality Gate passed

Issues
10 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@abose abose merged commit b44b204 into phcode-dev:main Mar 22, 2025
18 checks passed
@abose
Copy link
Member

abose commented Mar 22, 2025

This is an exceptionally well written piece of work @devvaannsh .

There are a few pending issues which will be addressed later:

  1. save vertical space by eliminating all the redundant title bars: image
  2. horizontal scrollbar not visible
  3. Increase speed of tab swithing anamations to be extremely fast.
  4. drag and drop between tab panes not working
  5. Protect against long file names: image
  6. drag and drop between tab panes and working set- optional for this release.

Since the code changes are isolated to the extension, merging.
LGTM. Merging it in.

@devvaannsh devvaannsh deleted the tb branch March 22, 2025 10:29
@abose abose mentioned this pull request Mar 30, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@devvaannsh @abose