Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
4b31e63
feat: tab bar working prototype
devvaannsh Mar 1, 2025
f379975
feat: add close button in tabs to remove the tab
devvaannsh Mar 1, 2025
62ac120
fix: tab bar for both panes gets closed when one pane tab bar gets empty
devvaannsh Mar 2, 2025
7d82ae6
refactor: styling issues
devvaannsh Mar 2, 2025
9447858
fix: tab bar not found in DOM when no files in pane
devvaannsh Mar 2, 2025
2738ae8
feat: add numberOfTabs preference feature
devvaannsh Mar 2, 2025
5749246
feat: add dirty icon if file is modified and show popup to save befor…
devvaannsh Mar 2, 2025
0438625
feat: add more option button in tab bar
devvaannsh Mar 2, 2025
95d55ea
feat: add dropdown in more-options
devvaannsh Mar 3, 2025
dcd0a33
feat: handle close all tabs from more-options button
devvaannsh Mar 6, 2025
fd6086b
feat: add reopen closed file in tab bar context menu
devvaannsh Mar 8, 2025
6dda8f2
feat: replace more options button with tabs right click handler
devvaannsh Mar 8, 2025
83b8f44
feat: create overflow button in tabbar
devvaannsh Mar 9, 2025
9a4f60d
feat: scroll to active tab when tab is not visible
devvaannsh Mar 10, 2025
74475b1
feat: implement close and close active tab in more options context menu
devvaannsh Mar 10, 2025
302b856
feat: add close button in overflow menu to work
devvaannsh Mar 10, 2025
c24efeb
feat: make dirty indicator work in overflow menu
devvaannsh Mar 11, 2025
e6f6e5e
feat: setup drag and drop for tab bar
devvaannsh Mar 11, 2025
7080809
fix: when sidebar gets resized the tabs get updated for correct overf…
devvaannsh Mar 12, 2025
90c48e2
fix: udpate tab bar when live preview gets resized
devvaannsh Mar 13, 2025
cf8f718
fix: tab bar disappearing bug
devvaannsh Mar 14, 2025
435d565
fix: if both panes have same file, we open that file only on desired …
devvaannsh Mar 15, 2025
ed2ff74
chore: improve styling
devvaannsh Mar 16, 2025
05f6aed
fix: tab bar disappearing when only one file is added in split view case
devvaannsh Mar 16, 2025
71cdd2b
fix: tab bar not appearing when opening image file
devvaannsh Mar 16, 2025
233f29a
chore: improve styling
devvaannsh Mar 16, 2025
12001d5
feat: implement close unmodified tabs feature
devvaannsh Mar 16, 2025
c601e61
chore: make tab bar style compatible for light theme
devvaannsh Mar 16, 2025
fd6bd12
fix: unit tests failing issue
devvaannsh Mar 17, 2025
344dfad
fix: integ tests failing
devvaannsh Mar 19, 2025
48b85b2
fix: integ tests failing in firefox
devvaannsh Mar 20, 2025
59e93c2
fix: duplicate tabs when tab bar was turned off and on again
devvaannsh Mar 20, 2025
cfc2655
feat: add tab bar toggle option inside view menu
devvaannsh Mar 20, 2025
9b14578
chore: update api docs
devvaannsh Mar 20, 2025
7a9f817
chore: add license
devvaannsh Mar 21, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions docs/API-Reference/command/Commands.md
Original file line number Diff line number Diff line change
Expand Up @@ -458,6 +458,12 @@ Opens theme settings
## VIEW\_HIDE\_SIDEBAR
Toggles sidebar visibility

**Kind**: global variable
<a name="TOGGLE_TABBAR"></a>

## TOGGLE\_TABBAR
Toggles tabbar visibility

**Kind**: global variable
<a name="VIEW_ZOOM_IN"></a>

Expand Down
4 changes: 4 additions & 0 deletions src/command/Commands.js
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,10 @@ define(function (require, exports, module) {
/** Toggles sidebar visibility */
exports.VIEW_HIDE_SIDEBAR = "view.toggleSidebar"; // SidebarView.js toggle()

/** Toggles tabbar visibility */
exports.TOGGLE_TABBAR = "view.toggleTabbar";
// extensionsIntegrated/TabBar/main.js

/** Zooms in the editor view */
exports.VIEW_ZOOM_IN = "view.zoomIn"; // ViewCommandHandlers.js _handleZoomIn()

Expand Down
12 changes: 10 additions & 2 deletions src/extensions/default/Phoenix-prettier/unittests.js
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,10 @@ define(function (require, exports, module) {

const PLATFORM_LINE_ENDINGS = (FileUtils.getPlatformLineEndings() === 'CRLF' ? "\r\n" : "\n");

function normalizeLineEndings(str) {
return str.replace(/\r\n/g, "\n");
}

require("./main");

const jsFile = require("text!../../../../test/spec/prettier-test-files/js/test.js"),
Expand Down Expand Up @@ -154,7 +158,9 @@ define(function (require, exports, module) {
createMockEditor(jsFile, "javascript", "/test.js");
testEditor.setSelection({line: 4, ch: 0}, {line: 6, ch: 0});
await BeautificationManager.beautifyEditor(testEditor);
expect(testEditor.document.getText(true)+ PLATFORM_LINE_ENDINGS).toBe(jsPrettySelectionOffset);
const actual = normalizeLineEndings(testEditor.document.getText(true) + PLATFORM_LINE_ENDINGS);
const expected = normalizeLineEndings(jsPrettySelectionOffset);
expect(actual).toBe(expected);
});

it("should not beautify editor on incomplete syntax selection for js", async function () {
Expand Down Expand Up @@ -209,7 +215,9 @@ define(function (require, exports, module) {
createMockEditor(htmlFile, "html", "/test.html");
testEditor.setSelection({line: 4, ch: 0}, {line: 6, ch: 0});
await BeautificationManager.beautifyEditor(testEditor);
expect(testEditor.document.getText(true)+ PLATFORM_LINE_ENDINGS).toBe(htmlPrettySelectionOffset);
const actual = normalizeLineEndings(testEditor.document.getText(true) + PLATFORM_LINE_ENDINGS);
const expected = normalizeLineEndings(htmlPrettySelectionOffset);
expect(actual).toBe(expected);
});

it("should not beautify editor on incomplete syntax selection for html", async function () {
Expand Down
Loading
Loading